Update api packages #110
Merged
Update api packages #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikatz
suggested changes
Jan 31, 2019
src/decrypt-api/decrypt-api.csproj
Outdated
| <PackageReference Include="Serilog.AspNetCore" Version="2.1.1" /> | ||
| <PackageReference Include="Microsoft.NETCore.App" Version="2.2.1" /> |
There was a problem hiding this comment.
AFAIK Microsoft.NETCore.App is not required, Microsoft.AspNetCore.App is enough.
for Microsoft.AspNetCore.App you shouldn't specify version since .netcore 2.2.
This is true for both encryptor and decryptor.
There was a problem hiding this comment.
Talking with Snyk about it
shaikatz
previously approved these changes
Jan 31, 2019
added 15 commits
February 3, 2019 15:08
omerlh
force-pushed
the
update_api_packages
branch
from
b7a3df1 to
ba3ef72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.