Skip to content

Commit

Permalink
stepping up the logging, simplify config example, re-order ci steps
Browse files Browse the repository at this point in the history
  • Loading branch information
suparious committed Jun 11, 2024
1 parent 022827b commit eb607a7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ jobs:
sleep 5
done
- name: Run tests
run: |
python -m unittest discover tests
env:
VALKEY_HOST: valkey
VALKEY_PORT: 6379
VALKEY_PORT: 6379
run: |
python -m unittest discover tests
3 changes: 0 additions & 3 deletions config-example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ servers:
- name: ServerOne
address: http://ServerOne:9100
network_interface: eno1
- name: ServerTwo
address: http://ServerTwo:9100
network_interface: enp7s0

dashboard:
host: 0.0.0.0
Expand Down
1 change: 1 addition & 0 deletions metrics/collector.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def collect_metrics(redis_client):
if __name__ == "__main__":
config = load_config()
redis_host = os.getenv('VALKEY_HOST', config.get('redis', {}).get('host', 'localhost'))
logger.info("Redis host: {redis_host}.")
redis_client = Redis(
host=redis_host,
port=config.get('redis', {}).get('port', 6379),
Expand Down

0 comments on commit eb607a7

Please sign in to comment.