Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance help http-shell by sections, navigations and click-executable example #2

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented Oct 23, 2020

Also bump to Kui version 6.0.7

This PR is just a suggestion for potential enhancement of help http-shell command. Please feel free to riff on it.

In this PR, @starpit and I ported help http-shell command to use Kui NavResponse, so the help output can be divided into sections. Users can click to navigate each sections. We also transform some examples to be click-executable. For example, users can click e.g. h set url http://127.0.0.1:8080 in the second screenshot to execute that command directly.

I bumped the Kui version to 6.0.7 to pick up some UX fixes necessary for this PR.

Screen Shot 2020-10-23 at 2 26 14 PM
Screen Shot 2020-10-23 at 2 26 15 PM
Screen Shot 2020-10-23 at 2 26 19 PM

I think this should also benefit from inline sidecar, when that is released soon in 9.1.0.
Screen Shot 2020-10-23 at 10 20 27 AM

@ujibang ujibang merged commit e4222ef into SoftInstigate:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants