Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calib_dlg: fix checkbox styling #7289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

buzzhuzz
Copy link
Contributor

Description

Do not set custom font and colour for checkbox caption labels. Update checkbox caption labels visibility depending on checkbox enabled state

Screenshots/Recordings/Graphs

Original behavior:
Screenshot from 2024-10-29 18-01-54 Screenshot from 2024-10-29 18-01-45 Screenshot from 2024-10-29 18-10-37

Updated behavior:
Screenshot from 2024-10-29 18-01-19 Screenshot from 2024-10-29 18-01-10 Screenshot from 2024-10-29 18-12-11

Tests

Linux with light theme only.

Do not set custom font and colour for checkbox caption lables
Update checkbox caption lables visibility depending on checkbox enabled
state
@buzzhuzz
Copy link
Contributor Author

@Patn1, please check if this PR resolves your issue you've brought up in #7199 (comment)

@Patn1
Copy link

Patn1 commented Oct 31, 2024

Thank you for tagging me and trying to optimise it. But I cannot really test this because the artefact only contains this PR without your other PR. So I may have to wait until the other is merged.

@buzzhuzz
Copy link
Contributor Author

buzzhuzz commented Nov 1, 2024

Oh, I see. Just pushed merged 7289 and 7199 into my fork https://github.com/buzzhuzz/OrcaSlicer/tree/refs/heads/test/orca-pr7289-validation
You could get binaries to test once the build is complete at https://github.com/buzzhuzz/OrcaSlicer/actions/runs/11621615427

@Patn1
Copy link

Patn1 commented Nov 1, 2024

Definitely better than before, but I think that its still not perfect.
image

Also it looks worse in dark mode now.
image

I don't know if it's possible, but could it be made like the slicer settings? So that the checkbox also has a white background when its selectable or a grey background when its not?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants