Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling object skirt. #6487

Merged
merged 12 commits into from
Sep 7, 2024
Merged

Conversation

vovodroid
Copy link
Contributor

@vovodroid vovodroid commented Aug 18, 2024

Implements individual object skirts, as requested in Individual skirts when printing by object. #3486 and Skirt around each object when using "by object" sequence #2652

Now skirt type could be
image

This PR based on several refactorings, including Configure skirt start point #6490 PR. To make review more easy each step was committed individually. Obviously them could be separated to different PRs or dropped.

I removed prime_extruder && first_layer && extruder_id == first_extruder_id as explicit object skirt is available.

Open question : do we need both common and object skirt together, probably with separate loop number?

All four combinations are possible.

Print by layer, common skirt:
image

Print by layer, object skirt:
image

Print by object , object skirt:
image

Print by object , common skirt (any meaning?):
image

@vovodroid vovodroid marked this pull request as draft August 19, 2024 06:58
@vovodroid vovodroid changed the title Object skirt refactoring and fix Enabling object skirt. Aug 22, 2024
@vovodroid vovodroid marked this pull request as ready for review August 22, 2024 15:56
@vovodroid
Copy link
Contributor Author

vovodroid commented Aug 24, 2024

@igiannakas , would you like to test this?

@igiannakas
Copy link
Contributor

Will do, no problem! From Tuesday though as I’m away from home for a few days :)

@SoftFever
Copy link
Owner

Love the idea!
Will review and test it soon

@SoftFever
Copy link
Owner

SoftFever commented Sep 7, 2024

Looks all good to me.
Just got a suggestion, can we name the options of the skirt type to: Combined and Per-object for clarity?

@vovodroid
Copy link
Contributor Author

Renamed:

image

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you!

@SoftFever SoftFever merged commit 415bede into SoftFever:main Sep 7, 2024
15 checks passed
@vovodroid vovodroid deleted the skirt-object-fix-pr branch September 7, 2024 15:54
This was referenced Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants