-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling object skirt. #6487
Enabling object skirt. #6487
Conversation
e9475dc
to
570c62a
Compare
570c62a
to
0a64d83
Compare
@igiannakas , would you like to test this? |
Will do, no problem! From Tuesday though as I’m away from home for a few days :) |
0a64d83
to
2a8b39a
Compare
Love the idea! |
Looks all good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thank you!
Implements individual object skirts, as requested in Individual skirts when printing by object. #3486 and Skirt around each object when using "by object" sequence #2652
Now skirt type could be
This PR based on several refactorings, including Configure skirt start point #6490 PR. To make review more easy each step was committed individually. Obviously them could be separated to different PRs or dropped.
I removed
prime_extruder && first_layer && extruder_id == first_extruder_id
as explicit object skirt is available.Open question : do we need both common and object skirt together, probably with separate loop number?
All four combinations are possible.
Print by layer, common skirt:
Print by layer, object skirt:
Print by object , object skirt:
Print by object , common skirt (any meaning?):