Fix small area flow comp regression and some other small tweaks #5844
+57
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small_area_infill_flow_compensation is per-region parameter, it's not necessary to iterate though all regions to check whether to create a model.
1. handle spaces/tabs/new lines etc 2. don't throw expection, fall back to no-op instead if parsing failed
… modifier didn't take effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix regression, always create SmallAreaInfillFlowCompensator model
small_area_infill_flow_compensationis per-region parameter, it's not necessary to iterate though all regions to check whether to create a model.Make SmallAreaInfillFlowCompensator more robust
Fixing an issue that changing small_area_infill_flow_compensation per modifier didn't take effect
Fixed #5780