This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Refacto #2
Merged
Refacto #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.js
Outdated
| const cors = require("cors"); | ||
| const fs = require("fs"); | ||
|
|
||
| const parseWeez = require("./parseWeez"); |
There was a problem hiding this comment.
Weez ça me fait rigoler comme nom mais bon, apparement c'est pas nous qui avons choisi !
src/index.js
Outdated
|
|
||
| app.get("/api/v1/:siret", (req, res) => { | ||
| const siret = req.params.siret; | ||
| if (!siret || siret === "" || siret.length != 14) { |
There was a problem hiding this comment.
le chaine vide est considérée comme false il me semble, pas besoin de rechecker ça après le !siret
UnbearableBear
approved these changes
Jul 31, 2019
|
c'est le moment de poser des questions :) |
added 2 commits
July 31, 2019 11:49
|
haha il y en aurait trop ! |
added 2 commits
August 19, 2019 09:27
SocialGroovyBot
pushed a commit
that referenced
this pull request
Sep 18, 2023
SocialGroovyBot
added a commit
that referenced
this pull request
Sep 18, 2023
## [1.7.2](v1.7.1...v1.7.2) (2023-09-18) ### Bug Fixes * upgrade docker image ([#2](#2)) ([28561c4](28561c4))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version minimale de l'api qui ne fait que siret2idcc avec la dernière version du fichier + pipeline