Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Merkle proof verifier contract #861

Merged
merged 17 commits into from
Jun 15, 2023
Merged

Conversation

doubledup
Copy link
Contributor

@doubledup doubledup commented Jun 15, 2023

Fixes: SNO-427

Following the release of paritytech/substrate#14176, this upgrades our relaychain to 0.9.43 which includes that revert. This also brings back our previous Merkle proof verifier, which doesn't use hash sorting.

@doubledup doubledup requested a review from vgeddes June 15, 2023 08:48
@doubledup doubledup self-assigned this Jun 15, 2023
@doubledup doubledup changed the base branch from main to vincent/outbound-queue June 15, 2023 08:55
@doubledup doubledup marked this pull request as ready for review June 15, 2023 10:05
@doubledup doubledup changed the title Revert Merkle proof verifier contract to verify validator indexes Revert Merkle proof verifier contract Jun 15, 2023
@doubledup doubledup marked this pull request as draft June 15, 2023 12:53
@doubledup doubledup marked this pull request as ready for review June 15, 2023 14:17
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (3db3ed5) 67.26% compared to head (dda33a5) 67.26%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           vincent/outbound-queue     #861   +/-   ##
=======================================================
  Coverage                   67.26%   67.26%           
=======================================================
  Files                          13       13           
  Lines                         223      223           
  Branches                       51       51           
=======================================================
  Hits                          150      150           
  Misses                         53       53           
  Partials                       20       20           
Impacted Files Coverage Δ
core/packages/contracts/src/ParachainClient.sol 56.66% <0.00%> (ø)
core/packages/contracts/src/BeefyClient.sol 64.00% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@doubledup doubledup merged commit 2622339 into vincent/outbound-queue Jun 15, 2023
@doubledup doubledup deleted the david/sno-427 branch June 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants