Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from bko-transfer-assets-via-bridge #850

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented May 30, 2023

Cumulus Companion: Snowfork/cumulus#30

@alistair-singh alistair-singh marked this pull request as ready for review May 30, 2023 20:52
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +6.63 🎉

Comparison is base (0467d5b) 64.44% compared to head (86632f4) 71.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   64.44%   71.07%   +6.63%     
==========================================
  Files          10       30      +20     
  Lines         225     1293    +1068     
  Branches       52        0      -52     
==========================================
+ Hits          145      919     +774     
- Misses         60      374     +314     
+ Partials       20        0      -20     
Impacted Files Coverage Δ
...achain/pallets/ethereum-beacon-client/src/impls.rs 0.00% <ø> (ø)
parachain/pallets/inbound-queue/src/lib.rs 75.60% <ø> (ø)
parachain/pallets/outbound-queue/src/lib.rs 84.37% <ø> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@doubledup doubledup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the cumulus submodule needs to be updated from c0c986 to the companion's 35e005.

@alistair-singh alistair-singh force-pushed the alistair/merge-bko-transfer-assets branch from 86632f4 to 30a71a6 Compare June 5, 2023 16:14
@alistair-singh alistair-singh merged commit 118b614 into main Jun 5, 2023
@alistair-singh alistair-singh deleted the alistair/merge-bko-transfer-assets branch June 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants