Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert to use BoundedVec for SyncCommitteePrepared" #819

Merged

Conversation

yrong
Copy link
Contributor

@yrong yrong commented May 3, 2023

This reverts commit 22274fa.
Only for diff compare and debug purpose for the issue here #811 (comment)

@yrong
Copy link
Contributor Author

yrong commented May 3, 2023

Another weird issue with const-generic-array is when running unit test without --release flag the memory access error found as following:

cargo test --verbose --package snowbridge-ethereum-beacon-client
Caused by:
  process didn't exit successfully: `/Users/yangrong/Projects/snowbridge/parachain/target/debug/deps/snowbridge_ethereum_beacon_client-0b7858a9df6f57aa` (signal: 10, SIGBUS: access to undefined memory)

and resolved with the --release option.

cargo test --release --verbose --package snowbridge-ethereum-beacon-client
test result: ok. 24 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.44s

@yrong yrong requested a review from vgeddes May 3, 2023 13:25
@yrong yrong force-pushed the ron/cache-milagro-g1-pubkeys-temp branch from 718fe52 to 8c2791a Compare May 4, 2023 01:43
@yrong yrong merged commit 8c2791a into ron/cache-milagro-g1-pubkeys May 4, 2023
@yrong yrong deleted the ron/cache-milagro-g1-pubkeys-temp branch May 4, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants