Fix find on-chain checkpoint #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
changed the title
claravanstaden
commented
Sep 27, 2024
| type ParachainConfig struct { | ||
| Endpoint string `mapstructure:"endpoint"` | ||
| MaxWatchedExtrinsics int64 `mapstructure:"maxWatchedExtrinsics"` | ||
| HeaderRedundancy uint64 `mapstructure:"headerRedundancy"` |
There was a problem hiding this comment.
Setting to capture the max headers in the ringbuffer: // https://github.com/paritytech/polkadot-sdk/blob/master/bridges/snowbridge/pallets/ethereum-client/src/lib.rs#L75
There was a problem hiding this comment.
Can we add a comment in the code describing the config item?
There was a problem hiding this comment.
Sure, 1956d87.
yrong
reviewed
Sep 27, 2024
| slotPeriodIndex := slot / syncCommitteePeriod | ||
|
|
||
| for index := startIndex; index >= endIndex; index-- { | ||
| totalStates := syncCommitteePeriod * h.protocol.HeaderRedundancy // Total size of the circular buffer, |
There was a problem hiding this comment.
Is total size of the circular buffer be 256*20=5120?
totalStates := h.protocol.Settings.EpochsPerSyncCommitteePeriod * h.protocol.HeaderRedundancy
yrong
reviewed
Sep 27, 2024
| @@ -18,7 +18,8 @@ | |||
| "sink": { | |||
| "parachain": { | |||
| "endpoint": "ws://127.0.0.1:11144", | |||
| "maxWatchedExtrinsics": 8 | |||
| "maxWatchedExtrinsics": 8, | |||
| "headerRedundancy": 20 | |||
There was a problem hiding this comment.
Can we just move the new config headerRedundancy to config.SpecSettings, then not much change required.
There was a problem hiding this comment.
That's true, but it is not really related to the Ethereum spec settings, which is why I didn't add it there.
vgeddes
approved these changes
Sep 30, 2024
claravanstaden
added a commit
that referenced
this pull request
Oct 1, 2024
* Initialize for westend * Update beacon checkpoint * add back in para threads * fix out of bounds error * Smoke tests on westend * Load config from env * Cleanup env * Remove penpal code * Cleanup * Update smoke tests * Add westend env * crontab smoke tests * Split as two tests * Fix typo * Remove assets/parachain non-exist * Revert change * Wait config from env * Load interval from env * Add alarm check no transfer * Adds paseo UI (#1276) * adds paseo UI * remove muse and bump versions * remove muse and bump versions * remove veth token * paseo things * fix subscan urls * revert version * fix versions * Update api package * Fix the merge * Remove unused * Fix find on-chain checkpoint (#1294) * fix wrap around * logs * doesnt have to be in the same period * testing something * fix * adds test and config * writer * fix compilation * remove temp building relayer * comment * bump version --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
claravanstaden
added a commit
that referenced
this pull request
Oct 2, 2024
* add back in para threads * fix out of bounds error * forward compatible * fix comment * move function back up * move again * Smoke test on westend (#1291) * Initialize for westend * Update beacon checkpoint * add back in para threads * fix out of bounds error * Smoke tests on westend * Load config from env * Cleanup env * Remove penpal code * Cleanup * Update smoke tests * Add westend env * crontab smoke tests * Split as two tests * Fix typo * Remove assets/parachain non-exist * Revert change * Wait config from env * Load interval from env * Add alarm check no transfer * Adds paseo UI (#1276) * adds paseo UI * remove muse and bump versions * remove muse and bump versions * remove veth token * paseo things * fix subscan urls * revert version * fix versions * Update api package * Fix the merge * Remove unused * Fix find on-chain checkpoint (#1294) * fix wrap around * logs * doesnt have to be in the same period * testing something * fix * adds test and config * writer * fix compilation * remove temp building relayer * comment * bump version --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> --------- Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 bugs in the find on-chain checkpoint method:
Added new config in Ansible scripts: https://github.com/Snowfork/snowbridge-infra-suite/pull/24/files#diff-0bdba71d49616abfe1a14b43ead54c6df64cdbfca68c8e4e5fe47bd4a1e3ae2bR29