This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
xcm integration test #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2023
| const INITIAL_FUND: u128 = 5_000_000_000 * ROCOCO_ED; | ||
| const CHAIN_ID: u64 = 15; | ||
| const DEST_PARA_ID: u32 = 1000; | ||
| const ETHEREUM_SOVEREIGN: [u8; 32] = |
There was a problem hiding this comment.
I use this name in start-services.sh.
Suggested change
| const ETHEREUM_SOVEREIGN: [u8; 32] = | |
| const SNOWBRIDGE_SOVEREIGN: [u8; 32] = |
Comment on lines
331
to
334
| let fee_asset = MultiAsset { | ||
| id: Concrete(MultiLocation { parents: 1, interior: Here }), | ||
| fun: Fungible(1_000_000_000_000), //1 ROC | ||
| }; |
There was a problem hiding this comment.
If you remove this fee asset, the call should pass. The fee_asset is the fee for the target chain(Ethereum). We charge 0 fees on the target chain so we make the fee asset WETH and ignore it when converting the xcm. There still will be an additional fee of DOT charged to the user for delivering the message on AssetHub when they call the reserve transfer extrinsic.
alistair-singh
force-pushed
the
ron/xcm-integration-test
branch
from
5b4373d to
589033b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏 Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:
Use Github semantic
linking
to address any open issues this PR relates to or closes.
Fixes # (issue number, if applicable)
Closes # (issue number, if applicable)
Checklist
Trequired)
You can remove the "Checklist" section once all have been checked. Thank you for your contribution!
✄ -----------------------------------------------------------------------------