feat: Add port/protocol for driver #962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alldoami
changed the title
|
I rebased the changes in main and made sure the docs were updated properly this time, should be ready for testing |
|
/ok-to-test sha=b6f792a |
|
Integration tests failure for b6f792a |
|
We fixed this test in a different PR, could you merge main into your branch and then we can merge your PR? |
|
Hi @alldoami, I have updated this PR with the latest from main. |
…vider-snowflake into pr-origin
|
/ok-to-test sha=0987fe9 |
1 similar comment
|
/ok-to-test sha=0987fe9 |
|
Integration tests failure for 0987fe9 |
1 task
|
#1238 closes this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to provide protocol and port options to the snowflake driver
Test Plan
References