feat: Support DIRECTORY option on stage create #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=da9cada |
|
I just realized I forgot to add support in ReadStage(). Let me add it. |
|
Integration tests success for da9cada |
|
/ok-to-test sha=6b99ebb |
|
Integration tests success for 6b99ebb |
alldoami
approved these changes
Feb 23, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds passing the
DIRECTORYoption ofCREATE STAGE(asdirectory) in the stage resource.This is only supported on create as the ALTER capabilities don't really align. As a result this PR suggests to ForceNew on
directorychange.Test Plan
This is currently not tested using acceptance tests