fix: Stream append only #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alldoami
reviewed
Aug 20, 2021
|
/ok-to-test sha=2546704 |
|
Integration tests success for 2546704 |
alldoami
approved these changes
Aug 23, 2021
|
/ok-to-test sha=546f1d3 |
|
Integration tests success for 546f1d3 |
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
This change updates the logic used when reading the data for the `snowflake_stream` resource to determine whether or not the stream is append only. Per the documentation at <https://docs.snowflake.com/en/sql-reference/sql/show-streams.html>, we can determine whether a stream is append only by checking the value of the `mode` for the stream. If the value is `APPEND_ONLY`, then the stream is append only. ## Test Plan * [X] Unit Tests * [x] Acceptance Tests If possible I would like feedback on the acceptance tests. I'm not terribly familiar with terraform provider testing. ## References * Related issue: <Snowflake-Labs#652>
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This change updates the logic used when reading the data for the `snowflake_stream` resource to determine whether or not the stream is append only. Per the documentation at <https://docs.snowflake.com/en/sql-reference/sql/show-streams.html>, we can determine whether a stream is append only by checking the value of the `mode` for the stream. If the value is `APPEND_ONLY`, then the stream is append only. ## Test Plan * [X] Unit Tests * [x] Acceptance Tests If possible I would like feedback on the acceptance tests. I'm not terribly familiar with terraform provider testing. ## References * Related issue: <Snowflake-Labs#652>
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the logic used when reading the data for the
snowflake_streamresource to determine whether or not the stream is append only.Per the documentation at https://docs.snowflake.com/en/sql-reference/sql/show-streams.html, we can determine whether a stream is append only by checking the value of the
modefor the stream. If the value isAPPEND_ONLY, then the stream is append only.Test Plan
If possible I would like feedback on the acceptance tests. I'm not terribly familiar with terraform provider testing.
References