Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partition_by error in external table #609

Merged

Conversation

rarusun
Copy link
Contributor

@rarusun rarusun commented Jul 20, 2021

This PR does the following:

  • Fixed partition_by from set to interface.
  • Renamed from partiion to partition.
  • Changed the length condition of the partition from >1 to >0.

Adresses: #448

Test Plan

  • acceptaces test

@rarusun rarusun requested a review from a team as a code owner July 20, 2021 02:02
@rarusun rarusun requested a review from alldoami July 20, 2021 02:02
@alldoami
Copy link
Contributor

/ok-to-test sha=3b8bb8d

@github-actions
Copy link

Integration tests success for 3b8bb8d

@alldoami alldoami merged commit ff82626 into Snowflake-Labs:main Jul 20, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants