Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SHOW_INITIAL_ROWS to stream resource #575

Merged
merged 23 commits into from
Jun 17, 2021
Merged

feat: Add SHOW_INITIAL_ROWS to stream resource #575

merged 23 commits into from
Jun 17, 2021

Conversation

alldoami
Copy link
Contributor

Addressing this feature request #537

Test Plan

  • acceptance tests
  • …

References

@alldoami alldoami requested a review from a team as a code owner June 15, 2021 23:40
@alldoami alldoami requested a review from edulop91 June 15, 2021 23:40
@alldoami alldoami changed the title Adoami/add initial rows stream feat: Add SHOW_INITIAL_ROWS to stream resource Jun 15, 2021
@github-actions
Copy link

Integration tests failure for bf28f637aadfd0dfdb80d58957b2c486bb620240

@github-actions
Copy link

Integration tests failure for f65224dcad6d1111cd814d7dcf51174550a8333e

@github-actions
Copy link

Integration tests failure for 5626435065ec2dd36144a5b5230e7e1d7adbc18b

@github-actions
Copy link

Integration tests failure for d85d147731c4784e247580fd075ebed2e096f493

@github-actions
Copy link

Integration tests success for 3497e6431fc48caf4a584063277f722b4fea5293

@github-actions
Copy link

Integration tests success for 909aee3f281910fc6b62ecf788080c230a36c79c

@github-actions
Copy link

Integration tests failure for 1eebe69841d7699d12503b387df5c9c1c519fb03

@github-actions
Copy link

Integration tests failure for 1bd48953ceeadd674600e3aff95537ba3b57e334

@github-actions
Copy link

Integration tests failure for d853bf5624332780adfe40493d76f72aff8eb9a4

@github-actions
Copy link

Integration tests failure for 1d0e07f8018d89aca4fbba59fac4cc5a0a21b61c

edulop91
edulop91 reviewed Jun 16, 2021
View reviewed changes
pkg/snowflake/stream.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests failure for 06121354f5963857626153850c1d94683f17b108

@github-actions
Copy link

Integration tests failure for 967b3e2c7b18e3a507309f98e3ac6d67c5fa2df7

@github-actions
Copy link

Integration tests failure for 992b871095871e07c6e6b9b9b8ea3592b7e036b0

@github-actions
Copy link

Integration tests failure for 8551cf28a61fe091f2df22ff0d4ec3ddfb7cafad

@github-actions
Copy link

Integration tests failure for 53a9c4a06335d2afbbd08d04d7aff892da14fdc4

@github-actions
Copy link

Integration tests failure for d8d3cb1657791cbdc001c6698e6ece7a9a0be494

@github-actions
Copy link

Integration tests failure for 570d9790b1569e2dfcd1191a1540c794ea73ab8c

@github-actions
Copy link

Integration tests success for c20832cc985095a3ddbed38b80baf4b329750c2e

@github-actions
Copy link

Integration tests success for 40b0c5550f2afacbbe55754eb8834e8e7736d22c

edulop91
edulop91 approved these changes Jun 17, 2021
View reviewed changes
Copy link

@edulop91 edulop91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than that small simplification

@github-actions
Copy link

Integration tests success for e23cf7c266f5537b5e52d4b208f87dc0f549ad72

@github-actions
Copy link

Integration tests success for 2c3b0723837d9a0fb2f7b5254799b173d72e2d54

@github-actions
Copy link

Integration tests success for 96e09248bbaeae94bc999ad83d32dd170b24c41e

@alldoami alldoami merged commit 3963193 into main Jun 17, 2021
@alldoami alldoami deleted the adoami/add-initial-rows-stream branch June 17, 2021 17:27
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
@alldoami @jtzero
feat: Add SHOW_INITIAL_ROWS to stream resource (Snowflake-Labs#575)
e42218b
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@alldoami @anton-chekanov
feat: Add SHOW_INITIAL_ROWS to stream resource (Snowflake-Labs#575)
8d9d03f
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@alldoami
feat: Add SHOW_INITIAL_ROWS to stream resource (Snowflake-Labs#575)
00da193
@snowflake-release-please snowflake-release-please bot mentioned this pull request May 25, 2022
Merged
This was referenced Nov 1, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 edulop91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alldoami @edulop91