Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/table clustering #548

Merged
merged 15 commits into from
May 21, 2021

Conversation

berosen
Copy link
Contributor

@berosen berosen commented May 18, 2021

This PR does the following:

  • Adds the ability to define clustering keys on a table resource.
  • Adds applicable tests
  • Updates docs

Test Plan

  • acceptance tests

Tested with
TF_ACC=1 go test -v ./... -run TestAcc_Table

References

@berosen berosen requested a review from a team as a code owner May 18, 2021 19:22
@berosen berosen requested a review from alldoami May 18, 2021 19:22
@alldoami
Copy link
Contributor

/ok-to-test sha=b746955

@github-actions
Copy link

Integration tests success for b746955

@berosen
Copy link
Contributor Author

berosen commented May 19, 2021

@alldoami Would you be able to give me a pointer for fixing the docs failure?

@alldoami
Copy link
Contributor

@berosen if you run make docs it should fix the errors! You shouldn't be manually editing the docs.

@berosen
Copy link
Contributor Author

berosen commented May 21, 2021

@berosen if you run make docs it should fix the errors! You shouldn't be manually editing the docs.

Thanks @alldoami! It seems like tfplugindocs generates docs differently depending on the directory it's being run from. I believe it should be good to go now.

@alldoami
Copy link
Contributor

/ok-to-test sha=f6083d1

@github-actions
Copy link

Integration tests success for f6083d1

Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alldoami alldoami merged commit e6eec5e into Snowflake-Labs:main May 21, 2021
@berosen berosen deleted the feature/table-clustering branch May 21, 2021 17:27
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants