Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make setup step to release instructions #504

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Add make setup step to release instructions #504

merged 3 commits into from
Mar 26, 2021

Conversation

alldoami
Copy link
Contributor

@alldoami alldoami commented Mar 25, 2021 •
edited
Loading

Was getting this problem:

latestVersionTag "0.23.2"
fileversion "0.23.3"
Error: tag does not match VERSION file
Usage:
  bff bump [flags]

Flags:
  -h, --help   help for bump

tag does not match VERSION file

Running make setup fixed it, so adding it as substep to release.

@alldoami alldoami requested a review from a team as a code owner March 25, 2021 17:23
@alldoami alldoami requested a review from edulop91 March 25, 2021 17:23
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #128876: Create release for tf sf provider and update docs.

edulop91
edulop91 reviewed Mar 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Integration tests success for 164c9ddcb99742850365cd2de72601cc7718363e

@alldoami alldoami requested a review from edulop91 March 25, 2021 17:43
@github-actions
Copy link

Integration tests success for 47a27570f3f709dd23e9732d2b604c7254becf94

@github-actions
Copy link

Integration tests success for 146bd8fffd50bd6f4f015c2390d23529ac12150d

@alldoami alldoami merged commit 3d29ed6 into main Mar 26, 2021
@alldoami alldoami deleted the adoami/ch128876/create-release-for-tf-sf-provider-and-update branch March 26, 2021 23:22
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@alldoami @anton-chekanov
Add make setup step to release instructions (Snowflake-Labs#504)
0cdf469
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@alldoami
Add make setup step to release instructions (Snowflake-Labs#504)
0778c30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 edulop91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alldoami @edulop91