Support adding, removing and changing the type of columns in tables #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2021 14:46
type of columns in tables. Renaming columns whilte retaining data is not made possible by this change, however.
|
Ooo this looks good, excited for a codeowner to review |
|
/ok-to-test sha=dc7fdab |
|
@edwardbrowncross could you update your branch with |
|
Integration tests success for dc7fdab |
|
/ok-to-test sha=54fb130 |
|
Integration tests success for 54fb130 |
alldoami
approved these changes
Apr 9, 2021
yohei1126
pushed a commit
to singlife/terraform-provider-snowflake
that referenced
this pull request
Apr 18, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour is to drop the table and all its data when a column is added, removed, or modified (#446, #421). This PR mostly fixes this.
Now supported without having to drop and recreate the table:
Partially supported:
Test Plan
References
#446
#421
ALTER TABLE documentation