Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using env variables we can make terraform to ignore account lvl settings #486

Closed
wants to merge 4 commits into from
Closed

Conversation

funes79
Copy link
Contributor

@funes79 funes79 commented Mar 7, 2021

Test Plan

  • acceptance tests

References

Usage

terraform plan
Output:

  # snowflake_task.retention_task will be updated in-place
  ~ resource "snowflake_task" "retention_task" {
        comment            = "deletes tables"
        database           = "IDB"
        enabled            = false
        id                 = "IDB|UTIL|RETENTION_TASK"
        name               = "RETENTION_TASK"
        schedule           = "USING CRON 0 23 * * * Europe/London"
        schema             = "UTIL"
      ~ session_parameters = {
          - "QUOTED_IDENTIFIERS_IGNORE_CASE" = "true" -> null
        }
        sql_statement      = "CALL retention(false)"
        warehouse          = "DEMO_XS_WH"
    }
Plan: 0 to add, 1 to change, 0 to destroy.

Setting environment variable to ignore account level setting QUOTED_IDENTIFIER_IGNORE_CASE:
export SNOWFLAKE_TASK_IGNORE_CASE=1
terraform plan
Output:

Plan: 0 to add, 0 to change, 0 to destroy.

@funes79 funes79 requested a review from a team as a code owner March 7, 2021 15:48
@funes79 funes79 requested a review from alldoami March 7, 2021 15:48
@ryanking
Copy link
Contributor

ryanking commented Mar 9, 2021

When querying for parameters, we should be able to filter out parameters whose 'level' is 'account'. I don't know for sure but it seems worth trying.

@funes79
Copy link
Contributor Author

funes79 commented Mar 9, 2021

Ok I will try to investigate that.

@alldoami
Copy link
Contributor

@funes79 any update on this?

…provider-snowflake into fix_bug474

Conflicts:
	docs/resources/stream.md
	pkg/provider/provider.go
	pkg/resources/stream.go
	pkg/resources/stream_acceptance_test.go
	pkg/resources/stream_test.go
@funes79 funes79 mentioned this pull request Mar 20, 2021
1 task
@funes79
Copy link
Contributor Author

funes79 commented Mar 20, 2021

@alldoami I created a new PR #499

@funes79 funes79 closed this Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants