feat: Account v1 readiness resource #3252

sfc-gh-jcieslak · 2024-12-06T14:12:56Z

Introduces refactor to already existing snowflake_account resource.

Changes

Refactored existing account resource
Completely rewritten acceptance tests
Introduced a return type from Create command that is used to parse org_name + acc_name that is later used in creating new resource id. The output is always returned. Adding another SQL calls to get this information may an issue. For example, when account was successfully created, but e.g. current organization_name couldn't be fetched; this situation will end up with created account, but with no connection to the terraform config of this account. This could be fixed by manually importing the resource. We can discuss this on Monday.

Next pr

data source
next account resource

fix tests

github-actions · 2024-12-06T16:44:04Z

Integration tests failure for ad871181d6e2ffda271e939980066b1857ff6f2c

github-actions · 2024-12-06T17:01:09Z

Integration tests failure for 9893fabbfeba275fadc4e7d979611d9cdf771634

pkg/sdk/testint/accounts_integration_test.go

pkg/sdk/accounts.go

sfc-gh-jmichalak · 2024-12-09T09:56:47Z

pkg/sdk/accounts.go

+	Region            string         `json:"region,omitempty"`
+}
+
+func ToAccountCreateResponse(v string) (*AccountCreateResponse, error) {


I think we could just implement UnmarshalJSON here.

we can but let's postpone it after V1 pls

sfc-gh-jmichalak · 2024-12-09T09:59:00Z

pkg/sdk/accounts_test.go

+
+	for _, tc := range testCases {
+		t.Run(tc.Name, func(t *testing.T) {
+			input := tc.RawInput


Nit: we can handle rawinput outside and simplify the setup here. Similarly with asserting errors.

pkg/sdk/identifier_helpers.go

sfc-gh-jmichalak · 2024-12-09T10:17:29Z

pkg/resources/account.go

+func ImportAccount(ctx context.Context, d *schema.ResourceData, meta any) ([]*schema.ResourceData, error) {
+	client := meta.(*provider.Context).Client
+
+	isOrgAdmin, err := client.ContextFunctions.IsRoleInSession(ctx, snowflakeroles.Orgadmin)


I guess we can extract it to a separate wrapper.

Let's leave this open. I'll address this in the following prs after v1.

pkg/resources/account.go

sfc-gh-jmichalak · 2024-12-09T10:25:01Z

pkg/resources/account.go

-}
+		// Setting from default to false and vice versa is not allowed because Snowflake throws an error on already disabled IsOrgAdmin
+		canUpdate := true
+		if (oldIsOrgAdmin.(string) == BooleanFalse && newIsOrgAdmin.(string) == BooleanDefault) ||


Can we manage this in diff suppress?

Hmm, not sure, maybe I did something different than we usually do with tri-value-bool or I just found its flaw here. Either way, I would like to leave it this way for now. Let's leave the comment and I'll check this after v1. Currently, it's working.

pkg/resources/account_state_upgraders.go

sfc-gh-asawicki · 2024-12-09T13:11:44Z

pkg/sdk/accounts.go

+	Region            string         `json:"region,omitempty"`
+}
+
+func ToAccountCreateResponse(v string) (*AccountCreateResponse, error) {


we can but let's postpone it after V1 pls

pkg/resources/account.go

github-actions · 2024-12-10T11:18:04Z

Integration tests failure for d2b6f6fade16d8d9e2c37c18846e28964e234879

🤖 I have created a release *beep* *boop* --- ## [0.100.0](v0.99.0...v0.100.0) (2024-12-12) ### 🎉 **What's new:** * Account v1 readiness ([#3236](#3236)) ([5df33a8](5df33a8)) * Account v1 readiness generated files ([#3242](#3242)) ([3df59dd](3df59dd)) * Account v1 readiness resource ([#3252](#3252)) ([8f5698d](8f5698d)) * Add a new account roles data source ([#3257](#3257)) ([b3d6b9e](b3d6b9e)) * Add account data source ([#3261](#3261)) ([6087fc9](6087fc9)) * Add all other functions and procedures implementations ([#3275](#3275)) ([7a6f68d](7a6f68d)) * Basic functions implementation ([#3269](#3269)) ([6d4a103](6d4a103)) * Basic procedures implementation ([#3271](#3271)) ([933335f](933335f)) * Docs, test, and missing parameter ([#3280](#3280)) ([10517f3](10517f3)) * Functions and procedures schemas and generated sources ([#3262](#3262)) ([9b70f87](9b70f87)) * Functions sdk update ([#3254](#3254)) ([fc1eace](fc1eace)) * Handle missing fields in function and procedure ([#3273](#3273)) ([53e7a0a](53e7a0a)) * Procedures schemas and generated sources ([#3263](#3263)) ([211ad46](211ad46)) * Procedures sdk update ([#3255](#3255)) ([682606a](682606a)) * Rework account parameter resource ([#3264](#3264)) ([15aa9c2](15aa9c2)) * Rework data types ([#3244](#3244)) ([05ada91](05ada91)) * support table data type ([#3274](#3274)) ([13401d5](13401d5)) * Tag association v1 readiness ([#3210](#3210)) ([04f6d54](04f6d54)) * Test imports and small fixes ([#3276](#3276)) ([a712195](a712195)) * Unsafe execute v1 readiness ([#3266](#3266)) ([c4f1e8f](c4f1e8f)) * Use new data types in sql builder for functions and procedures ([#3247](#3247)) ([69f677a](69f677a)) ### 🔧 **Misc** * Add ShowByID filtering generation ([#3227](#3227)) ([548ec42](548ec42)) * Adress small task-related todos ([#3243](#3243)) ([40de9ae](40de9ae)) * Apply masking ([#3234](#3234)) ([c209a8a](c209a8a)) * fix missing references in toOpts and changes with newlines ([#3240](#3240)) ([246547f](246547f)) * function tests ([#3279](#3279)) ([5af6efb](5af6efb)) * Improve config builders ([#3207](#3207)) ([425787c](425787c)) * Revert to proper env ([#3238](#3238)) ([5d4ed3b](5d4ed3b)) * Use service user for ci ([#3228](#3228)) ([2fb50d7](2fb50d7)) ### 🐛 **Bug fixes:** * Make blocked_roles_field optional in OAuth security integrations ([#3267](#3267)) ([7197b57](7197b57)) * Minor fixes ([#3231](#3231)) ([1863bf6](1863bf6)) * Minor fixes 2 ([#3230](#3230)) ([73b7e74](73b7e74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-jcieslak added 11 commits December 6, 2024 12:28

wip

e3ed26e

fix tests

wip

4e65a6f

wip

36e9db8

wip

99e499a

wip

886cad6

wip

fd03f33

wip

2bcec11

wip

b61d78c

wip

ad87118

wip

bbcbc2f

wip

9893fab

sfc-gh-jcieslak marked this pull request as ready for review December 6, 2024 14:46

sfc-gh-jcieslak requested review from sfc-gh-asawicki and sfc-gh-jmichalak December 9, 2024 05:38

sfc-gh-jmichalak requested changes Dec 9, 2024

View reviewed changes

sfc-gh-asawicki previously approved these changes Dec 9, 2024

View reviewed changes

changes after review

d2b6f6f

sfc-gh-jcieslak dismissed sfc-gh-asawicki’s stale review via d2b6f6f December 10, 2024 08:51

sfc-gh-jcieslak requested review from sfc-gh-asawicki and sfc-gh-jmichalak December 10, 2024 09:11

sfc-gh-jmichalak approved these changes Dec 10, 2024

View reviewed changes

sfc-gh-jmichalak mentioned this pull request Dec 10, 2024

feat: Rework account parameter resource #3264

Merged

2 tasks

sfc-gh-asawicki approved these changes Dec 10, 2024

View reviewed changes

sfc-gh-jcieslak merged commit 8f5698d into main Dec 11, 2024
8 of 9 checks passed

sfc-gh-jcieslak deleted the account-v1-readiness-resource-modification branch December 11, 2024 10:32

snowflake-release-please bot mentioned this pull request Dec 11, 2024

chore(main): release 0.100.0 #3237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Account v1 readiness resource #3252

feat: Account v1 readiness resource #3252

sfc-gh-jcieslak commented Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

sfc-gh-jmichalak Dec 9, 2024

sfc-gh-asawicki Dec 9, 2024

sfc-gh-jmichalak Dec 9, 2024

sfc-gh-jcieslak Dec 10, 2024

sfc-gh-jmichalak Dec 9, 2024

sfc-gh-jcieslak Dec 10, 2024 •

edited

Loading

sfc-gh-jmichalak Dec 9, 2024

sfc-gh-jcieslak Dec 10, 2024

sfc-gh-asawicki Dec 9, 2024

github-actions bot commented Dec 10, 2024

feat: Account v1 readiness resource #3252

feat: Account v1 readiness resource #3252

Conversation

sfc-gh-jcieslak commented Dec 6, 2024 • edited Loading

Changes

Next pr

github-actions bot commented Dec 6, 2024

github-actions bot commented Dec 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sfc-gh-jcieslak Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 10, 2024

sfc-gh-jcieslak commented Dec 6, 2024 •

edited

Loading

sfc-gh-jcieslak Dec 10, 2024 •

edited

Loading