Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mark V1 ready preview features part 2 #3225

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: Mark V1 ready preview features part 2 #3225

merged 4 commits into from
Nov 27, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Nov 26, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 47defdeb83049eaea27b35d6bcded9b434df065f

@sfc-gh-jmichalak sfc-gh-jmichalak force-pushed the v1-ready-preview-resources branch from 47defde to 4c29c8c Compare November 26, 2024 16:47
@github-actions GitHub Actions
Copy link

Integration tests cancelled for 4c29c8c306cfa64551d1993e3ed1f320f42b5eea

@github-actions GitHub Actions
Copy link

Integration tests cancelled for 224060f867b1d072a760d6bb541b887488e57ec0

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review November 26, 2024 17:44
sfc-gh-asawicki
sfc-gh-asawicki approved these changes Nov 26, 2024
View reviewed changes
pkg/datasources/system_get_aws_sns_iam_policy.go
@@ -30,7 +31,7 @@ var systemGetAWSSNSIAMPolicySchema = map[string]*schema.Schema{

func SystemGetAWSSNSIAMPolicy() *schema.Resource {
return &schema.Resource{
ReadContext: TrackingReadWrapper(datasources.SystemGetAwsSnsIamPolicy, ReadSystemGetAWSSNSIAMPolicy),
ReadContext: PreviewFeatureReadWrapper(string(previewfeatures.SystemGetAWSSNSIAMPolicyDatasource), TrackingReadWrapper(datasources.SystemGetAwsSnsIamPolicy, ReadSystemGetAWSSNSIAMPolicy)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SystemGetAWSSNSIAMPolicyDatasource would be nicer as SystemGetAwsSnsIamPolicyDatasource - I know that golang prefers uppercased abbreviations but in such cases it's just wrong and unreadable - in our code, In multiple places we do a first-letter-only uppercasing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I copied it from somewhere else and overlooked it. This can be probably changed during the data source rework, for consistency.

@sfc-gh-jmichalak sfc-gh-jmichalak force-pushed the v1-ready-preview-resources branch from 4562d1a to 17a7d48 Compare November 26, 2024 18:40
@github-actions GitHub Actions
Copy link

Integration tests failure for 4562d1a27ab8a05053add7291d9c979e0c2b16a6

@github-actions GitHub Actions
Copy link

Integration tests failure for 17a7d484af948517405d237c8426ed586055e5e4

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 8e0c161 into v1-ready Nov 27, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the v1-ready-preview-resources branch November 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jmichalak @sfc-gh-asawicki