Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle external change of secret type #3141

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: handle external change of secret type #3141

wants to merge 7 commits into from

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

@sfc-gh-fbudzynski sfc-gh-fbudzynski commented Oct 17, 2024 •
edited
Loading

Changes

  • Added secret_type computed filed to secret resources
  • Added CustomDiff for handling external change of secret_type
  • Refactored show_and_describe_handlers for flat describe_output and show_output
  • Tested external change of secret type for each resource

Test Plan

  • acceptance tests

References

@github-actions GitHub Actions
Copy link

Integration tests failure for 510df15a291f193bd9733d423af438b312e12ef9

@github-actions GitHub Actions
Copy link

Integration tests failure for 7d90d7b0db639fdcbea2fdaf6f212aefd883b9f2

@github-actions GitHub Actions
Copy link

Integration tests failure for dd38109b6b71fb199b4eb6cc0b03d03cb437c1a1

@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review October 18, 2024 14:37
@sfc-gh-fbudzynski sfc-gh-fbudzynski changed the title fix: handle secret type external change fix: handle external change of secret type Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki Awaiting requested review from sfc-gh-asawicki

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-fbudzynski