Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Row access policy data source v1 #3066

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Sep 12, 2024

  • rework row access policy data source
  • adjust sdk
  • add missing filtering
  • add output fields
  • add description to policy resource
  • add more acceptance tests
  • improve examples
  • add an entry to the migration guide

Test Plan

  • acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/show-row-access-policies

Copy link

Integration tests failure for d083683af62d684db379e4a6618bdb61013d6667

Copy link

Integration tests failure for f1d38024539663a6d254fbc1d5c9a4ee83cf0125

Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed

Base automatically changed from row-access-policy-v1 to main September 13, 2024 09:02
@sfc-gh-jmichalak sfc-gh-jmichalak dismissed sfc-gh-jcieslak’s stale review September 13, 2024 09:02

The base branch was changed.

Copy link

Integration tests failure for 4fb1f3307ee2466a335f71ace4817d664e868177

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 138a288 into main Sep 13, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the row-access-policy-ds-v1 branch September 13, 2024 11:40
sfc-gh-fbudzynski pushed a commit that referenced this pull request Sep 19, 2024
<!-- Feel free to delete comments as you fill this in -->
- rework row access policy data source
- adjust sdk
- add missing filtering
- add `output` fields
- add description to policy resource
- add more acceptance tests
- improve examples
- add an entry to the migration guide
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->

## References
<!-- issues documentation links, etc  -->
https://docs.snowflake.com/en/sql-reference/sql/show-row-access-policies
sfc-gh-jmichalak pushed a commit that referenced this pull request Sep 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.96.0](v0.95.0...v0.96.0)
(2024-09-18)

Essential GA object readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)).

:exclamation: Migration guide: [v0.95.0 ->
v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960)

### 🎉 **What's new:**

* V1 redesign of resources and data sources
* Row access policy
([#3066](#3066))
([#3063](#3063))
* Resource monitor
([#3052](#3052))
([#3064](#3064))
* Masking policy
([#3078](#3078))
([#3083](#3083))
* SDK upgrades
* External volume
([#3033](#3033))
* Authentication policy
([#2937](#2937))
([#3068](#3068))
([#3061](#3061))


### 🔧 **Misc**

* Clean up old test object helpers
([#3049](#3049))
* Add example of granting role to multiple objects
([#3047](#3047))
* Update readme and objects rework state
([#3046](#3046))

### 🐛 **Bug fixes:**

* Fix model grants
([#3070](#3070))
* Fix database show by and resource logic
([#3055](#3055))
* Fix default secondary roles option import
([#3041](#3041))
* Fix sweepers for warehouse and database
([#3057](#3057))
* Fix views permadiff
([#3079](#3079))
* Update v0.95.0 migration guide
([#3062](#3062))

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants