feat: Add user parameters to resource #2968

sfc-gh-asawicki · 2024-07-30T10:07:05Z

This is the first of the next few changes being a part of the user resource rework. It includes:

adding user parameters to the user resource schema
adding the parameters collection to user schema
testing the behavior of parameters on user
a bunch of TODOs to move parameters definitions was left for the next PRs (this one is already too big)
missing assertions and config builders generated

Checks for setting TIMEZONE may fail (skip added to the test messing with our account; it was cleaned with ALTER ACCOUNT UNSET TIMEZONE but still this test from other branches may interfere).

Additionally:

logic to handle parameters has been slightly improved and made a bit more generic (with changes to databases and schemas; function to read database parameters was replaced with a more generic solution fixing SNOW-1480106)
one of the account parameters was messing with the change, so the test was temporarily skipped
new github issues added to the known issues list

It does not include (it will be handled in the following PRs):

checking quotes for DATE_INPUT_FORMAT and DATE_OUTPUT_FORMAT
checking if zero is allowed for CLIENT_MEMORY_LIMIT
handling snowflake_network_policy_attachment
handling snowflake_user_public_keys
setting diff suppressions and validations for the parameters (it will be handled in the next PR)
moving the parameters logic fully to the SDK
reworking other attributes on the user resource
adding more acceptance tests

… and schema

github-actions · 2024-07-30T11:19:56Z

Integration tests failure for 5174c87c5531014d827200c39dd522cccf7414a2

github-actions · 2024-07-30T14:49:43Z

Integration tests failure for c008d12e4a3938a860203252d05ee27b22b3cce3

pkg/resources/user.go

docs/resources/user.md

pkg/resources/user.go

pkg/resources/user_parameters_test.go

pkg/resources/user_parameters.go

github-actions · 2024-08-02T13:20:38Z

Integration tests failure for fae051d0a0f85082913856534366a06c5c19392c

templates/resources/user.md.tmpl

github-actions · 2024-08-05T09:46:14Z

Integration tests failure for 8c6ce69c13122ea891446d7df97be0fd6ac658eb

sfc-gh-jcieslak · 2024-08-05T11:25:06Z

pkg/sdk/parsers_test.go

+		},
+		{
+			Name:       "list with brackets - with double quotes",
+			Value:      `"one","two","three"`,


This one should have brackets (same in the next test case)

I will change the name of the test in the follow-up PR

github-actions · 2024-08-05T12:10:52Z

Integration tests failure for 81243d8030eb6f9413df1e4b9591198a0a3dffd0

🤖 I have created a release *beep* *boop* --- ## [0.95.0](v0.94.1...v0.95.0) (2024-09-04) ### 🎉 **What's new:** * Add change_tracking, row access policy and aggregation policy to views ([#2988](#2988)) ([1f88bb1](1f88bb1)) * Add fully_qualified_name to all resources ([#2990](#2990)) ([1b0462f](1b0462f)) * Add identifier parsers ([#2957](#2957)) ([824ec52](824ec52)) * Add identifier with arguments ([#2979](#2979)) ([00ae1c5](00ae1c5)) * Add timeouts block to cortex ([#3004](#3004)) ([34d764b](34d764b)) * Add user parameters to resource ([#2968](#2968)) ([f4ae380](f4ae380)) * Conclude user rework ([#3036](#3036)) ([23e4625](23e4625)) * database role v1 readiness ([#3014](#3014)) ([c4db255](c4db255)) * Identifier with arguments for procedure and external function ([#2987](#2987)) ([f13cc5c](f13cc5c)) * Rework user resource ([#3026](#3026)) ([bde2638](bde2638)), closes [#1572](#1572) * Rework users datasource ([#3030](#3030)) ([751239b](751239b)), closes [#2902](#2902) * Upgrade view sdk ([#2969](#2969)) ([ef2d50a](ef2d50a)) * View rework part 2 ([#3021](#3021)) ([e05377d](e05377d)) * View rework part 3 ([#3023](#3023)) ([195b41c](195b41c)) ### 🔧 **Misc** * Add annotation about fully_qualified_name and fix handling granteeName ([#3009](#3009)) ([94e6345](94e6345)) * Apply identifier conventions ([#2996](#2996)) ([5cbea84](5cbea84)) * apply identifier conventions to grants ([#3008](#3008)) ([d7780ae](d7780ae)) * Clean collection utils ([#3028](#3028)) ([426ddb1](426ddb1)) * Clean old assertions ([#3029](#3029)) ([ad657eb](ad657eb)) * Conclude identifiers rework ([#3011](#3011)) ([c1b53f3](c1b53f3)) * Improve user test and add manual test for user default database and role ([#3035](#3035)) ([6cb0b4e](6cb0b4e)) * Use new identifier with arguments in function, external function and procedure grants ([#3002](#3002)) ([5053f8b](5053f8b)) * User improvements ([#3034](#3034)) ([65b64d7](65b64d7)) ### 🐛 **Bug fixes:** * database tests and introduce a new parameter ([#2981](#2981)) ([3bae7f6](3bae7f6)) * Fix custom diffs for fields with diff supression ([#3032](#3032)) ([2499602](2499602)) * Fix default secondary roles after BCR 2024_07 ([#3040](#3040)) ([2ca465a](2ca465a)), closes [#3038](#3038) * Fix issues 2972 and 3007 ([#3020](#3020)) ([1772387](1772387)) * Fix known user resource issues ([#3013](#3013)) ([a5dfeac](a5dfeac)) * identifier issues ([#2998](#2998)) ([6fb76b7](6fb76b7)) * minor issues ([#3027](#3027)) ([467b06e](467b06e)), closes [#3015](#3015) [#2807](#2807) [#3025](#3025) * Nuke users ([#2971](#2971)) ([0d90cc9](0d90cc9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-asawicki added 26 commits July 30, 2024 10:47

add user parameters to resource starts here

a761520

Add user parameters to schema (WIP)

290e70e

Use context funcs in user schema def

d430300

Prepare user parameters schema (WIP)

d5b2157

Add the rest of user parameters

3ae2d09

Add parameter docs enricher

65b1c4f

Remove unnecessary Snowflake docs reference

f7b815c

Use user parameters schema inside the resource

f4bf7d5

Regenerate config builder and resource assertions

0d51b8a

Add user parameters custom diff

cbe44b3

Handle user parameters read

b10df4d

Handle user parameters create

b1190c0

Handle user parameters update

f125152

Add set/unset parameters logic to the user resource

f955c73

Test parameters setting/unsetting through resource

36fdaa1

Add unit test to mappers

f9fe53b

Add gh issues

0424e13

Use new resource parameter methods in database, schema, and warehouse

2e52cf7

Extract resource parameters commons

98fd231

Use generic create for database, shared database, secondary database,…

fa163ab

… and schema

Extract schema parameters

4a4f0c0

Run make pre-push

e2d3ca0

Make the parameter methods unexported

9ea6bc9

Add migration guide

5174c87

Fix a few things before the review

202b83f

Update migration guide

e4ea65d

Fix acceptance tests

e8ea492

sfc-gh-asawicki marked this pull request as ready for review July 30, 2024 11:47

sfc-gh-asawicki requested a review from sfc-gh-jcieslak July 30, 2024 11:59

Fix one more test

c008d12

sfc-gh-jcieslak reviewed Jul 31, 2024

View reviewed changes

pkg/resources/user.go Show resolved Hide resolved

pkg/resources/user.go Outdated Show resolved Hide resolved

pkg/resources/user.go Outdated Show resolved Hide resolved

docs/resources/user.md Show resolved Hide resolved

Add missing issues to the list

9bd3da5

sfc-gh-jmichalak requested changes Jul 31, 2024

View reviewed changes

pkg/resources/user.go Show resolved Hide resolved

pkg/resources/user_parameters_test.go Show resolved Hide resolved

pkg/resources/user_parameters.go Outdated Show resolved Hide resolved

sfc-gh-asawicki added 3 commits August 2, 2024 14:22

Fix after review

32df79f

Use new methods in resources and datasources

e7923b3

Run pre-push

fae051d

sfc-gh-asawicki requested review from sfc-gh-jmichalak and sfc-gh-jcieslak August 2, 2024 12:30

sfc-gh-jcieslak previously approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'main' into add-user-parameters-to-resource

8c6ce69

sfc-gh-asawicki dismissed sfc-gh-jcieslak’s stale review via 8c6ce69 August 5, 2024 08:50

sfc-gh-asawicki requested a review from sfc-gh-jcieslak August 5, 2024 08:50

sfc-gh-jcieslak previously approved these changes Aug 5, 2024

View reviewed changes

sfc-gh-jmichalak previously approved these changes Aug 5, 2024

View reviewed changes

templates/resources/user.md.tmpl Outdated Show resolved Hide resolved

sfc-gh-asawicki added 2 commits August 5, 2024 13:18

Fix the tests after using the sdk function

a7cf32f

Fix the migration reference

81243d8

sfc-gh-asawicki dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-jcieslak via 81243d8 August 5, 2024 11:21

sfc-gh-jcieslak approved these changes Aug 5, 2024

View reviewed changes

sfc-gh-jmichalak approved these changes Aug 5, 2024

View reviewed changes

sfc-gh-asawicki merged commit f4ae380 into main Aug 5, 2024
8 of 9 checks passed

sfc-gh-asawicki deleted the add-user-parameters-to-resource branch August 5, 2024 12:19

snowflake-release-please bot mentioned this pull request Aug 5, 2024

chore(main): release 0.95.0 #2977

Merged

sfc-gh-asawicki mentioned this pull request Aug 21, 2024

snowflake_user_parameter resource is missing #2938

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add user parameters to resource #2968

feat: Add user parameters to resource #2968

sfc-gh-asawicki commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 5, 2024

sfc-gh-jcieslak Aug 5, 2024

sfc-gh-asawicki Aug 5, 2024

github-actions bot commented Aug 5, 2024

feat: Add user parameters to resource #2968

feat: Add user parameters to resource #2968

Conversation

sfc-gh-asawicki commented Jul 30, 2024 • edited Loading

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 5, 2024

sfc-gh-jcieslak Aug 5, 2024

Choose a reason for hiding this comment

sfc-gh-asawicki Aug 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2024

sfc-gh-asawicki commented Jul 30, 2024 •

edited

Loading