-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better tests poc #2917
Merged
Merged
feat: Better tests poc #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests failure for 5ce3bea66516f8a9f6ed137b9e65016c78530af6 |
sfc-gh-jmichalak
previously approved these changes
Jul 11, 2024
sfc-gh-jcieslak
previously approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poggers
sfc-gh-asawicki
dismissed stale reviews from sfc-gh-jcieslak and sfc-gh-jmichalak
via
July 11, 2024 12:17
4408b19
sfc-gh-jcieslak
previously approved these changes
Jul 11, 2024
sfc-gh-jmichalak
previously approved these changes
Jul 11, 2024
Integration tests failure for 4408b19cb15ddced2b712d053ff3b19bfbdeb73c |
sfc-gh-asawicki
dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-jcieslak
via
July 11, 2024 14:01
e641aa0
sfc-gh-jcieslak
approved these changes
Jul 11, 2024
Integration tests failure for e641aa0379800364480324c2b6d146a0ebd34d0d |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jul 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.94.0](v0.93.0...v0.94.0) (2024-07-26) ### 🎉 **What's new:** * Add missing session parameters ([#2936](#2936)) ([4ce662d](4ce662d)) * Adjust user SDK ([#2947](#2947)) ([1127bb3](1127bb3)) * Better tests poc ([#2917](#2917)) ([ef496c2](ef496c2)) * Introduce assertions generators part1 ([#2952](#2952)) ([1582a9f](1582a9f)) * Introduce assertions generators part2 ([#2956](#2956)) ([f715e8a](f715e8a)) * network policy v1 readiness ([#2914](#2914)) ([3408c3f](3408c3f)) * Rework schema datasource ([#2954](#2954)) ([f70e40e](f70e40e)) * Rework schema resource ([#2955](#2955)) ([400a5c8](400a5c8)) * Role v1 readiness ([#2916](#2916)) ([32c7690](32c7690)) * Schema SDK upgrade ([#2945](#2945)) ([bca0836](bca0836)) * Streamlit v1 readiness ([#2930](#2930)) ([aa42260](aa42260)) ### 🔧 **Misc** * Remove deprecation from unsafe execute ([#2941](#2941)) ([ed712d7](ed712d7)) * Update documentation ([#2931](#2931)) ([da98bc3](da98bc3)) ### 🐛 **Bug fixes:** * ATTRIBUTE set(string) parsing for cortex search service ([#2953](#2953)) ([70a1c9a](70a1c9a)) * external function header parsing and add missing privileges ([#2961](#2961)) ([9d882fe](9d882fe)) * Fix sync_password field for Azure scim clients ([#2950](#2950)) ([6781133](6781133)) * Fix tests and relax warehouse validations ([#2959](#2959)) ([dd01ce9](dd01ce9)), closes [#2948](#2948) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking for some time and finally had a moment to put all this in writing. This is a PoC of more readable and reusable assertions (resource and snowflake object ones) and better config builders for acceptance tests. Check the details in the README.