Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2700: update grantedOn check #2701

Closed
wants to merge 1 commit into from

Conversation

sgrzemski
Copy link

Hello team,

Fixing MR for #2700

The Grants.Show returns GrantedOn == "ROLE" even if the ownership is granted for a database role(same in Snowflake UI), This checks compares "DATABASE ROLE" to "ROLE" and it fails to create the ownership resource. I've changed the comparison method to fix this behavior.

Kind regards,
Szymon

References

#2700

The Grants.Show returns GrantedOn == "ROLE" (same in Snowflake UI), but this checks compares "DATABASE ROLE" to "ROLE" and it fails to create the ownership resource.
@sfc-gh-jcieslak
Copy link
Collaborator

Hey hey,
I'm sorry, but we needed some additional things like acceptance tests and we wanted to go with a different approach of solving the issue. Since the change was pretty straightforward forward we created our own pr (here). Although we really appreciate the effort, I think we can close this one.

@sgrzemski
Copy link
Author

Hello @sfc-gh-jcieslak ,
Sure that's fine. Please remember about coauthoring your changes :)

@sgrzemski sgrzemski closed this Apr 12, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey, in the linked pr the approach is completely different and none of the changes were taken from this change. If some parts were taken from the original pr, we will coauthor in the new change. Nevertheless, thanks again, for the reported issue and the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants