Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust dynamic tables after BCR-1543 #2664

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix: Adjust dynamic tables after BCR-1543 #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/resources/dynamic_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ var dynamicTableSchema = map[string]*schema.Schema{
},
"scheduling_state": {
Type: schema.TypeString,
Description: "Displays RUNNING for dynamic tables that are actively scheduling refreshes and SUSPENDED for suspended dynamic tables.",
Description: "Displays ACTIVE for dynamic tables that are actively scheduling refreshes and SUSPENDED for suspended dynamic tables.",
Computed: true,
},
"last_suspended_on": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/sdk/dynamic_table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ var AllDynamicTableInitializes = []DynamicTableInitialize{DynamicTableInitialize
type DynamicTableSchedulingState string

const (
DynamicTableSchedulingStateRunning DynamicTableSchedulingState = "RUNNING"
DynamicTableSchedulingStateActive DynamicTableSchedulingState = "ACTIVE"
DynamicTableSchedulingStateSuspended DynamicTableSchedulingState = "SUSPENDED"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/sdk/testint/dynamic_table_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func TestInt_DynamicTableAlter(t *testing.T) {
entities, err := client.DynamicTables.Show(ctx, sdk.NewShowDynamicTableRequest().WithLike(&sdk.Like{Pattern: sdk.String(dynamicTable.Name)}))
require.NoError(t, err)
require.Equal(t, 1, len(entities))
require.Equal(t, sdk.DynamicTableSchedulingStateRunning, entities[0].SchedulingState)
require.Equal(t, sdk.DynamicTableSchedulingStateActive, entities[0].SchedulingState)

err = client.DynamicTables.Alter(ctx, sdk.NewAlterDynamicTableRequest(dynamicTable.ID()).WithSuspend(sdk.Bool(true)))
require.NoError(t, err)
Expand All @@ -148,7 +148,7 @@ func TestInt_DynamicTableAlter(t *testing.T) {
entities, err = client.DynamicTables.Show(ctx, sdk.NewShowDynamicTableRequest().WithLike(&sdk.Like{Pattern: sdk.String(dynamicTable.Name)}))
require.NoError(t, err)
require.Equal(t, 1, len(entities))
require.Equal(t, sdk.DynamicTableSchedulingStateRunning, entities[0].SchedulingState)
require.Equal(t, sdk.DynamicTableSchedulingStateActive, entities[0].SchedulingState)
})

t.Run("alter with refresh", func(t *testing.T) {
Expand Down
Loading