Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showbyid method tests #2648

Merged
merged 6 commits into from
Apr 16, 2024
Merged

fix: showbyid method tests #2648

merged 6 commits into from
Apr 16, 2024

Conversation

sfc-gh-swinkler
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler commented Mar 25, 2024

fixes SNOW-1003308

Test Plan

  • acceptance tests

References

Copy link

Integration tests failure for 1cfd2dc677595231620f9fad0a36af161be1c268

pkg/sdk/testint/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/external_tables_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/external_functions_gen.go Outdated Show resolved Hide resolved
pkg/sdk/testint/external_functions_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/external_functions_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/functions_gen.go Outdated Show resolved Hide resolved
pkg/sdk/procedures_gen.go Outdated Show resolved Hide resolved
pkg/sdk/testint/alerts_integration_test.go Show resolved Hide resolved
Copy link

github-actions bot commented Apr 1, 2024

Integration tests failure for 8e3aaced5c98235b7f3d6ed83b53409bf49c0343

Copy link

github-actions bot commented Apr 3, 2024

Integration tests success for 35ab31d41f3b3645623bf8d48e2162a35f459642

sfc-gh-jcieslak
sfc-gh-jcieslak previously approved these changes Apr 3, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Run pre-push

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 3, 2024 09:56
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Apr 3, 2024
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

pkg/sdk/testint/external_functions_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/external_functions_integration_test.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 9daa66fc04ee10921b5a7e39fa8dab8212feec9e

Copy link

Integration tests failure for 3f6a9ace5bff1d70bab8eefae5b805d48cb5dd52

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 16, 2024 15:08
Copy link

Integration tests success for 3f6a9ace5bff1d70bab8eefae5b805d48cb5dd52

@sfc-gh-swinkler sfc-gh-swinkler merged commit ff5e617 into main Apr 16, 2024
6 of 8 checks passed
@sfc-gh-swinkler sfc-gh-swinkler deleted the showbyid-test branch April 16, 2024 18:22
Copy link

Integration tests failure for 9443e43e71f8ac1f3f173849b449d47238f7cf3a

sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.0](v0.88.0...v0.89.0)
(2024-04-18)


### 🎉 **What's new:**

* Update target objects for privilege-granting resources
([#2688](#2688))
([74e2b6b](74e2b6b))


### 🔧 **Misc**

* Handle generic check destroy in acceptance tests
([#2716](#2716))
([63a5324](63a5324))
* Initialize the SDK client in fewer places
([#2710](#2710))
([382bfc1](382bfc1))


### 🐛 **Bug fixes:**

* Adds case statement for ObjectTypeUser in ShowObjectParameter.
([#2675](#2675))
([23a3341](23a3341))
* diffs always occurring when multiple columns exist
([#2686](#2686))
([3275ad4](3275ad4))
* Fix issues
[#2679](#2679)
[#2721](#2721)
([#2723](#2723))
([b0c9dd4](b0c9dd4))
* Fix several small issues
([#2697](#2697))
([e3f6a15](e3f6a15))
* granting ownership on database roles
([#2703](#2703))
([88944e7](88944e7))
* network policy update
([#2647](#2647))
([8126b28](8126b28))
* Rename grants_redesign_desgin_decisions.md to grants_redesign_design_…
([#2691](#2691))
([5000b2b](5000b2b))
* renames in update operations
([#2702](#2702))
([793c879](793c879))
* showbyid method tests
([#2648](#2648))
([ff5e617](ff5e617))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants