-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate Warehouse resource + datasource to new SDK #1792
Conversation
Integration tests failure for ade0909ca94ca4004750cacb40cababc43c46332 |
ade0909
to
132848f
Compare
Integration tests failure for 132848f3ae7fdaa83cd7dcb3f2ee2563d0322af5 |
132848f
to
ec32513
Compare
Integration tests failure for ec32513b95fe0111f8c7abc1769306de1283235d |
ec32513
to
c34ec5f
Compare
Integration tests failure for c34ec5faad1b0f8dbd56fe4cc5c6ecaef432f3ce |
c34ec5f
to
c89fd1c
Compare
Integration tests failure for c89fd1c7cfbb2556682ee3f31ebf16bf11356c6c |
c89fd1c
to
ea4d55e
Compare
Integration tests success for ea4d55eddf4f15347509f3cc2c50e15798ff3e6d |
ea4d55e
to
8ef0964
Compare
Integration tests success for 8ef0964ed68fcb2278f6e13dd33f1d8e71c91bd2 |
StatementTimeoutInSeconds *uint `ddl:"parameter" db:"STATEMENT_TIMEOUT_IN_SECONDS"` | ||
} | ||
|
||
type WarehouseUnsetField string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to use an Unset struct rather than making an enum type for this
return fmt.Errorf("exactly one of Suspend, Resume, AbortAllQueries, NewName, Set, Unset, SetTags and UnsetTags must be set: %w", err) | ||
} | ||
|
||
if opts.Suspend != nil && *opts.Suspend && opts.Resume != nil && *opts.Resume { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkEclsuviePointers is a cool function. we should do something similiar for checking that both are not true. maybe making a rules validation lib
Pendings string | ||
Failed string | ||
Suspended string | ||
Uuid string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be UUID
@@ -19,6 +19,16 @@ func Int(i int) *int { | |||
return &i | |||
} | |||
|
|||
// Uint returns a pointer to the given uint. | |||
func Uint(i uint) *uint { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure that i like this over having int type
@sfc-gh-ngaberel This is a breaking change for existing declaration's of a given warehouse that are in lower case. I got this error when testing another change I was working on │ Error: expected warehouse_size to be one of [XSMALL SMALL MEDIUM LARGE XLARGE XXLARGE XXXLARGE X4LARGE X5LARGE X6LARGE], got xsmall
|
@sfc-gh-ngaberel this introduced a breaking change for the |
Hi @AnatEzra81, thanks for reporting this, I'm talking to other teams to figure out what the validation rules should actually be (if any). Could you create a separate issue so we can track this? |
Some API changes:
snowflake_warehouse
resource has been removed. Usesnowflake_tag_association
instead.snowflake_warehouse
resource fieldswarehouse_size
,scaling_policy
andwarehouse_type
now accept a subset of the options they previously accepted.Test Plan
References