Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing Google Cloud computed property api_gcp_service_accou… #1776

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: Add missing Google Cloud computed property api_gcp_service_accou… #1776

merged 1 commit into from
May 30, 2023

Conversation

mwiewior
Copy link
Contributor

@mwiewior mwiewior commented May 4, 2023

Fixes #1775

Tests:

(base) ➜  terraform-provider-snowflake git:(issue-1775) ✗ go test github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources -run "^TestAcc_ApiIntegration$" -v
=== RUN   TestAcc_ApiIntegration
--- PASS: TestAcc_ApiIntegration (7.64s)
PASS

@mwiewior mwiewior changed the title feat:Add missing Google Cloud computed property api_gcp_service_accou… fix:Add missing Google Cloud computed property api_gcp_service_accou… May 4, 2023
@mwiewior mwiewior changed the title fix:Add missing Google Cloud computed property api_gcp_service_accou… fix: Add missing Google Cloud computed property api_gcp_service_accou… May 4, 2023
@mwiewior
Copy link
Contributor Author

hey @sfc-gh-swinkler - any chance to get this minor things reviewed and merged, it would be very helpful for our GCP integrations...

@mwiewior
Copy link
Contributor Author

hey @sfc-gh-ngaberel could you please take a look at this minor one?

sfc-gh-swinkler
sfc-gh-swinkler approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-swinkler sfc-gh-swinkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-swinkler sfc-gh-swinkler merged commit 1dd0672 into Snowflake-Labs:main May 30, 2023
@sfc-gh-swinkler
Copy link
Collaborator

@mwiewior thank you for your contribution!

@snowflake-release-please snowflake-release-please bot mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snowflake_api_integration does not provide read-only api_gcp_service_account property
2 participants
@mwiewior @sfc-gh-swinkler