Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix invalid style of log messages and exclude underscores #1265

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

mnagaa
Copy link
Contributor

@mnagaa mnagaa commented Oct 9, 2022

Summary

This PR fixes the following invalid style:

  • Error messages should start with lowercase, do not use UPPERCASE.
  • Do not declare variable and function names with underscores.

Test Plan

  • acceptance tests

docs: update document
@sfc-gh-swinkler sfc-gh-swinkler changed the title refactor: fix invalid style of log messages and exclude underscores fix: fix invalid style of log messages and exclude underscores Oct 11, 2022
@sfc-gh-swinkler sfc-gh-swinkler merged commit aede29f into Snowflake-Labs:main Oct 11, 2022
@sfc-gh-swinkler
Copy link
Collaborator

@mnagaa thank you for your contribution!

@mnagaa mnagaa deleted the refactor/fix-stylecheck branch October 12, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants