Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverted enable_multiple_grants #1225

Conversation

ChrisIsidora
Copy link
Contributor

Revert for enable_multiple_grants because it does not work properly as intended and is causing side effects. One of the biggest side effects is that because the roles are part of the id, when a role is added to an existing object grant, the id changes, which in turn triggers the resource to be replaced which means that the current roles will be revoked then granted again. This causes a significant disruption when users that are using the affected roles are running a query when the grants are being rolled out.

This side effect was only noticed by us now because we were creating new grants with the new id format which includes the roles in the id itself. For our old grant resources this is not the case because it was still using the id format that excluded the roles prior to the introduction of the enable_multiple_grants feature.

Test Plan

  • acceptance tests
  • unit tests

References

@ChrisIsidora
Copy link
Contributor Author

@sfc-gh-swinkler Can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant