Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Streams on views #1112

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Conversation

gouline
Copy link
Contributor

@gouline gouline commented Jul 9, 2022

Allow streams on views (rather than tables), now that it's in public preview.

Test Plan

  • acceptance tests

References

@sfc-gh-jalin
Copy link
Contributor

Hi @gouline, can you rebase please? And you can ignore the failing slack-notifications step, we are currently working on that as a side project

@sfc-gh-jalin
Copy link
Contributor

/ok-to-test sha=fab210e

@github-actions
Copy link

Integration tests failure for fab210e

@sfc-gh-jalin
Copy link
Contributor

/ok-to-test sha=40568af

@sfc-gh-jalin
Copy link
Contributor

Looks like something's up with CI 🤨

make: *** No rule to make target 'test-acceptance'.  Stop.

Think I got the wrong commit ID, it's running now

@gouline
Copy link
Contributor Author

gouline commented Jul 14, 2022

Sorry, that was my bad - I initially just merged the main branch in (fab210e) and then did a rebase like you asked (40568af). Looks good now.

@github-actions
Copy link

Integration tests success for 40568af

@sfc-gh-jalin sfc-gh-jalin merged commit 7a27b40 into Snowflake-Labs:main Jul 14, 2022
@gouline gouline deleted the feat/stream-on-view branch July 14, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants