fix: Minor fixes 2 #3230

sfc-gh-jmichalak · 2024-11-27T10:30:22Z

prove that using network policy with lowercase characters in oauth integration fails in Snowflake
update the migration guide regarding migrating provider configuration
rename datasource to data source
add missing examples and fix some examples in the docs
add notes about missing fields (they will be done in SNOW-1844996)
adjust documentation for provider configuration
improve quoting with import and resource configuration examples
- some examples of replication and grants were not changed because they show a nicer setup, IMO - can discuss about this
add info about external changes not being detected for certain fields or resource types
change infobox format for some notes ([!WARNING] -> !> Note) because it isn't rendered properly in the registry
fix empty using in view masking policies
add links to documentation of the referenced resources
adjust enum validations to use sdkValidation with SDK converter function instead of StringInSlice
address feat: Use new data types in sql builder for functions and procedures #3247 by improving the documentation
update lists in v1-preparations files

Test Plan

acceptance tests

integration tests

References

#3198
#3251

TODO (next PRs):

check the migration guide once again

github-actions · 2024-11-27T12:49:13Z

Integration tests cancelled for 8124496ad14651194b20fa927222ebd21029a5c7

github-actions · 2024-11-27T12:52:54Z

Integration tests cancelled for 11698ee662b3c495cac2be38c66175629cce5902

github-actions · 2024-11-27T15:29:29Z

Integration tests failure for db308146853fab572d383ecf2b6384af16c92152

github-actions · 2024-11-29T17:51:58Z

Integration tests failure for 8395c609a4a9bd5a738062e2b2f32f824d1f3580

github-actions · 2024-12-02T18:38:15Z

Integration tests failure for de2fb0d661bdd12a45d12bac08f7728fdf5b80db

github-actions · 2024-12-03T17:04:19Z

Integration tests failure for 666e998418b6e83586f8e622cffb6795a6b72e2c

github-actions · 2024-12-05T17:19:41Z

Integration tests failure for d4eab0a3b5f388957bd5e61d8cb1ee85fe008584

github-actions · 2024-12-05T23:13:28Z

Integration tests failure for ba2df04197584223a2d5847a4ae6fe9e0adcd6f9

docs/guides/unassigning_policies.md

docs/resources/grant_account_role.md

docs/resources/secondary_connection.md

docs/resources/stream_on_view.md

pkg/resources/stream_on_view.go

pkg/resources/task.go

sfc-gh-jcieslak · 2024-12-09T06:48:10Z

pkg/resources/view_acceptance_test.go

+	projectionPolicy, projectionPolicyCleanup := acc.TestClient().ProjectionPolicy.CreateProjectionPolicy(t)
+	t.Cleanup(projectionPolicyCleanup)
+
+	// generators currently don't handle lists of objects, so use the old way


I think they do now, but I'm fine with leaving this for now as is

Probably, but this was reworked a while ago. Let's leave this for now.

pkg/resources/view_acceptance_test.go

pkg/resources/diff_suppressions_test.go

docs/resources/grant_database_role.md

docs/resources/row_access_policy.md

docs/resources/secondary_connection.md

docs/resources/stream_on_external_table.md

docs/resources/stream_on_view.md

docs/resources/task.md

docs/resources/warehouse.md

pkg/resources/database_commons.go

pkg/resources/diff_suppressions_test.go

v1-preparations/LIST_OF_STABLE_RESOURCES_FOR_V1.md

github-actions · 2024-12-10T12:05:14Z

Integration tests cancelled for 6f39bbed4c1fb79c3501d2c03ca4375efe7542c7

sfc-gh-jcieslak · 2024-12-10T12:29:10Z

docs/resources/database.md

@@ -9,6 +9,9 @@ description: |-

 !> **Note** The provider does not detect external changes on database type. In this case, remove the database of wrong type manually with `terraform destroy` and recreate the resource. It will be addressed in the future.

+!> **Note** A database cannot be dropped successfully if it contains network rule-network policy associations. The error looks like `098507 (2BP01): Cannot drop database DATABASE as it includes network rule - policy associations.
+`. Currently, the provider does not unassign such objects automatically. Before dropping the resource, first unassign the network rule from the relevant objects. See [guide](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/guides/unassigning_policies) for more details.
+


Question: Will this be rendered as one note? + I would leave ` in the :12 line

I just checked in https://registry.terraform.io/tools/doc-preview and it looks correct. But I agree this should be improved - will do in the next PR.

pkg/resources/diff_suppressions_test.go

github-actions · 2024-12-10T14:32:22Z

Integration tests failure for 00cf7babed2a6dfbef805a4be3debaa28daa11af

🤖 I have created a release *beep* *boop* --- ## [0.100.0](v0.99.0...v0.100.0) (2024-12-12) ### 🎉 **What's new:** * Account v1 readiness ([#3236](#3236)) ([5df33a8](5df33a8)) * Account v1 readiness generated files ([#3242](#3242)) ([3df59dd](3df59dd)) * Account v1 readiness resource ([#3252](#3252)) ([8f5698d](8f5698d)) * Add a new account roles data source ([#3257](#3257)) ([b3d6b9e](b3d6b9e)) * Add account data source ([#3261](#3261)) ([6087fc9](6087fc9)) * Add all other functions and procedures implementations ([#3275](#3275)) ([7a6f68d](7a6f68d)) * Basic functions implementation ([#3269](#3269)) ([6d4a103](6d4a103)) * Basic procedures implementation ([#3271](#3271)) ([933335f](933335f)) * Docs, test, and missing parameter ([#3280](#3280)) ([10517f3](10517f3)) * Functions and procedures schemas and generated sources ([#3262](#3262)) ([9b70f87](9b70f87)) * Functions sdk update ([#3254](#3254)) ([fc1eace](fc1eace)) * Handle missing fields in function and procedure ([#3273](#3273)) ([53e7a0a](53e7a0a)) * Procedures schemas and generated sources ([#3263](#3263)) ([211ad46](211ad46)) * Procedures sdk update ([#3255](#3255)) ([682606a](682606a)) * Rework account parameter resource ([#3264](#3264)) ([15aa9c2](15aa9c2)) * Rework data types ([#3244](#3244)) ([05ada91](05ada91)) * support table data type ([#3274](#3274)) ([13401d5](13401d5)) * Tag association v1 readiness ([#3210](#3210)) ([04f6d54](04f6d54)) * Test imports and small fixes ([#3276](#3276)) ([a712195](a712195)) * Unsafe execute v1 readiness ([#3266](#3266)) ([c4f1e8f](c4f1e8f)) * Use new data types in sql builder for functions and procedures ([#3247](#3247)) ([69f677a](69f677a)) ### 🔧 **Misc** * Add ShowByID filtering generation ([#3227](#3227)) ([548ec42](548ec42)) * Adress small task-related todos ([#3243](#3243)) ([40de9ae](40de9ae)) * Apply masking ([#3234](#3234)) ([c209a8a](c209a8a)) * fix missing references in toOpts and changes with newlines ([#3240](#3240)) ([246547f](246547f)) * function tests ([#3279](#3279)) ([5af6efb](5af6efb)) * Improve config builders ([#3207](#3207)) ([425787c](425787c)) * Revert to proper env ([#3238](#3238)) ([5d4ed3b](5d4ed3b)) * Use service user for ci ([#3228](#3228)) ([2fb50d7](2fb50d7)) ### 🐛 **Bug fixes:** * Make blocked_roles_field optional in OAuth security integrations ([#3267](#3267)) ([7197b57](7197b57)) * Minor fixes ([#3231](#3231)) ([1863bf6](1863bf6)) * Minor fixes 2 ([#3230](#3230)) ([73b7e74](73b7e74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-jmichalak added 2 commits November 27, 2024 11:29

Prove issue 3229

8124496

Update migration guide

11698ee

Update data source docs

db30814

Fix empty USING in views masking policies

8395c60

sfc-gh-jmichalak changed the title ~~chore: Prove issue 3229~~ fix: Minor fixes 2 Nov 29, 2024

sfc-gh-jmichalak added 2 commits December 2, 2024 17:26

Merge remote-tracking branch 'origin/main' into prove-issue-3229

f0f3c8a

Small fixes

de2fb0d

sfc-gh-jmichalak mentioned this pull request Dec 3, 2024

feat: Tag association v1 readiness #3210

Merged

2 tasks

Cleanup

666e998

sfc-gh-jmichalak added 3 commits December 5, 2024 13:40

Link related resources and cleanup examples

8a9ca39

Merge remote-tracking branch 'origin/main' into prove-issue-3229

3203300

Add a guide for unassiging policies

d4eab0a

sfc-gh-jmichalak requested review from sfc-gh-asawicki and sfc-gh-jcieslak and removed request for sfc-gh-asawicki December 5, 2024 21:11

pre push

ba2df04

sfc-gh-jmichalak marked this pull request as ready for review December 5, 2024 21:25

sfc-gh-jcieslak reviewed Dec 9, 2024

View reviewed changes

sfc-gh-jmichalak added 2 commits December 9, 2024 11:35

Update provider version in tracking package

bcecc29

Address issue 3251

4f3b725

sfc-gh-asawicki requested changes Dec 9, 2024

View reviewed changes

sfc-gh-jmichalak added 2 commits December 10, 2024 13:01

Review

6f39bbe

Merge remote-tracking branch 'origin/main' into prove-issue-3229

00cf7ba

sfc-gh-jcieslak reviewed Dec 10, 2024

View reviewed changes

sfc-gh-jcieslak approved these changes Dec 10, 2024

View reviewed changes

sfc-gh-asawicki self-requested a review December 10, 2024 15:11

sfc-gh-jmichalak mentioned this pull request Dec 10, 2024

feat: Rework account parameter resource #3264

Merged

2 tasks

sfc-gh-asawicki approved these changes Dec 10, 2024

View reviewed changes

sfc-gh-jmichalak merged commit 73b7e74 into main Dec 10, 2024
8 of 9 checks passed

sfc-gh-jmichalak deleted the prove-issue-3229 branch December 10, 2024 15:46

snowflake-release-please bot mentioned this pull request Dec 10, 2024

chore(main): release 0.100.0 #3237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Minor fixes 2 #3230

fix: Minor fixes 2 #3230

sfc-gh-jmichalak commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

sfc-gh-jcieslak Dec 9, 2024

sfc-gh-jmichalak Dec 10, 2024

github-actions bot commented Dec 10, 2024

sfc-gh-jcieslak Dec 10, 2024

sfc-gh-jmichalak Dec 10, 2024

github-actions bot commented Dec 10, 2024

fix: Minor fixes 2 #3230

fix: Minor fixes 2 #3230

Conversation

sfc-gh-jmichalak commented Nov 27, 2024 • edited Loading

Test Plan

References

TODO (next PRs):

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

sfc-gh-jcieslak Dec 9, 2024

Choose a reason for hiding this comment

sfc-gh-jmichalak Dec 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 10, 2024

sfc-gh-jcieslak Dec 10, 2024

Choose a reason for hiding this comment

sfc-gh-jmichalak Dec 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 10, 2024

sfc-gh-jmichalak commented Nov 27, 2024 •

edited

Loading