Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES parameter #3116

Closed
1 task done
yuukiyamanaka opened this issue Oct 7, 2024 · 2 comments
Closed
1 task done
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@yuukiyamanaka
Copy link

Use Cases or Problem Statement

When I tried to set ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES parameter using snowflake_account_parameter resource,

resource "snowflake_account_parameter" "enforce_network_rules_for_internal_stages" {
  key   = "ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES"
  value = "true"
}

I encounter the below error:

Error: Invalid object parameter: ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES

with snowflake_account_parameter.enforce_network_rules_for_internal_stages

Category

category:resource

Object type(s)

resource:account_parameter

Proposal

I think this parameter is still in public preview, so the provider does not support it yet.
Do you have plans to add this parameter? If not, I would like to submit a PR.

How much impact is this issue causing?

Low

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@yuukiyamanaka yuukiyamanaka added the feature-request Used to mark issues with provider's missing functionalities label Oct 7, 2024
@sfc-gh-asawicki
Copy link
Collaborator

Hey @yuukiyamanaka. Thanks for reaching out to us.

We will shortly visit the rework of snowflake_account and snowflake_account_parameter resources (check https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD and https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/REMAINING_GA_OBJECTS.MD). We will add this parameter then.

One more important thing to mention: as I can see in the docs https://docs.snowflake.com/en/sql-reference/parameters#enforce-network-rules-for-internal-stages, this parameter is currently in public preview. We focus on the generally available features in this provider because the preview features tend to change.

Before adding this parameter, you can also use the snowflake_unsafe_execute resource to set this parameter through terraform.

@yuukiyamanaka
Copy link
Author

Thank you for response!
I understand the current situation.

sfc-gh-jmichalak added a commit that referenced this issue Dec 20, 2024
<!-- Feel free to delete comments as you fill this in -->
- Add missing parameters based on the docs and output of SHOW PARAMETERS
IN ACCOUNT
- Add missing unit tests and implementations
- Add missing validations
- Relax validations for ints - just validate if they are non-negative
- Update docs
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
#3044 
#3116
#3245

## TODO
- Do not add missing user parameters - this will be done in
SNOW-1844996. Here, they are added only to account and session level
- More acceptance and integration tests should be done on a separate
account. This should be done during account resource follow-up
(SNOW-1866453)
sfc-gh-asawicki pushed a commit that referenced this issue Dec 20, 2024
<!-- Feel free to delete comments as you fill this in -->
- Add missing parameters based on the docs and output of SHOW PARAMETERS
IN ACCOUNT
- Add missing unit tests and implementations
- Add missing validations
- Relax validations for ints - just validate if they are non-negative
- Update docs
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
#3044 
#3116
#3245

## TODO
- Do not add missing user parameters - this will be done in
SNOW-1844996. Here, they are added only to account and session level
- More acceptance and integration tests should be done on a separate
account. This should be done during account resource follow-up
(SNOW-1866453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Development

No branches or pull requests

2 participants