Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add "CREATE NOTEBOOK" privilege to the list of allowed plural object types for all and future lists in snowflake_grant_privileges_to_database_role resource. #2960

Closed
1 task
anita0918 opened this issue Jul 25, 2024 · 3 comments
Closed
1 task

[Feature]: Add "CREATE NOTEBOOK" privilege to the list of allowed plural object types for all and future lists in snowflake_grant_privileges_to_database_role resource. #2960

anita0918 opened this issue Jul 25, 2024 · 3 comments
Assignees
@sfc-gh-jcieslak
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@anita0918
Copy link

Use Cases or Problem Statement

All the schemas in the firm are managed schemas and are controlled by a terraform role. To create the Notebooks within underlying managed schema, user needs to apply CREATE NOTEBOOK on the schema which is not possible using current versions of terraform modules as notebook isn't included in the list of allowed plural object types.

Nested Schema for on_schema_object

The object type of the schema object on which privileges will be granted. Valid values are: AGGREGATION POLICY | ALERT | AUTHENTICATION POLICY | CORTEX SEARCH SERVICE | DATA METRIC FUNCTION | DYNAMIC TABLE | EVENT TABLE | EXTERNAL TABLE | FILE FORMAT | FUNCTION | GIT REPOSITORY | HYBRID TABLE | IMAGE REPOSITORY | ICEBERG TABLE | MASKING POLICY | MATERIALIZED VIEW | MODEL | NETWORK RULE | PACKAGES POLICY | PASSWORD POLICY | PIPE | PROCEDURE | PROJECTION POLICY | ROW ACCESS POLICY | SECRET | SERVICE | SESSION POLICY | SEQUENCE | STAGE | STREAM | TABLE | TAG | TASK | VIEW | STREAMLIT

Category

category:grants

Object type(s)

resource:database_role

Proposal

No response

How much impact is this issue causing?

Medium

Additional Information

No response

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@anita0918 anita0918 added the feature-request Used to mark issues with provider's missing functionalities label Jul 25, 2024
@sfc-gh-jcieslak sfc-gh-jcieslak self-assigned this Jul 25, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @anita0918 👋
I'll create a pr today and It'll be a part of the next release.

@sfc-gh-jcieslak sfc-gh-jcieslak mentioned this issue Jul 25, 2024
Merged
sfc-gh-jcieslak added a commit that referenced this issue Jul 26, 2024
@sfc-gh-jcieslak
fix: external function header parsing and add missing privileges (#2961)
9d882fe 
Changes:
- Add CREATE NOTEBOOK privilege for on all/future grants (and other
missing privileges based on the [Snowflake
documentation](https://docs.snowflake.com/en/sql-reference/sql/grant-privilege)):
#2960
- Fix header parsing in external function
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @anita0918
The privilege was added in the latest provider version (v0.94.0). Could you please upgrade and confirm it works on your end?

@sfc-gh-jcieslak
Copy link
Collaborator

Closing due to long inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jcieslak sfc-gh-jcieslak

Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anita0918 @sfc-gh-jcieslak