Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network policy update #2647

Merged
merged 4 commits into from
Apr 16, 2024
Merged

fix: network policy update #2647

merged 4 commits into from
Apr 16, 2024

Conversation

sfc-gh-swinkler
Copy link
Collaborator

fixes #2593

Test Plan

  • acceptance tests

References

Copy link

Integration tests failure for 6d4fc141ef50c86962c5cae97d911cac07efefba

Copy link

Integration tests failure for 2e0e837b95476c85e6d69359b2c7c403bbfd9ca9

g.KeywordOptions().SQL("SET"),
).
OptionalQueryStructField(
"Add",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs ADD and REMOVE both take only one network rule and not the list like CREATE/ALTER SET. Is this the error in the docs or in the implementation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs are wrong, it should be a list, i tried one network rule, and it failed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the doc discuss channel, and then you can close this comment

@sfc-gh-swinkler sfc-gh-swinkler changed the title fix: network rules update fix: network policy update Apr 13, 2024
Copy link

gitguardian bot commented Apr 13, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10002067 Triggered GitHub Access Token f9b7255 .github/GITHUB_README.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

Integration tests failure for f9b72554c173d724cdcd4cae85b351fafb2398c1

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 16, 2024 15:03
Copy link

Integration tests success for f9b72554c173d724cdcd4cae85b351fafb2398c1

@sfc-gh-asawicki sfc-gh-asawicki merged commit 8126b28 into main Apr 16, 2024
9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the network-rules branch April 16, 2024 17:10
sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.0](v0.88.0...v0.89.0)
(2024-04-18)


### 🎉 **What's new:**

* Update target objects for privilege-granting resources
([#2688](#2688))
([74e2b6b](74e2b6b))


### 🔧 **Misc**

* Handle generic check destroy in acceptance tests
([#2716](#2716))
([63a5324](63a5324))
* Initialize the SDK client in fewer places
([#2710](#2710))
([382bfc1](382bfc1))


### 🐛 **Bug fixes:**

* Adds case statement for ObjectTypeUser in ShowObjectParameter.
([#2675](#2675))
([23a3341](23a3341))
* diffs always occurring when multiple columns exist
([#2686](#2686))
([3275ad4](3275ad4))
* Fix issues
[#2679](#2679)
[#2721](#2721)
([#2723](#2723))
([b0c9dd4](b0c9dd4))
* Fix several small issues
([#2697](#2697))
([e3f6a15](e3f6a15))
* granting ownership on database roles
([#2703](#2703))
([88944e7](88944e7))
* network policy update
([#2647](#2647))
([8126b28](8126b28))
* Rename grants_redesign_desgin_decisions.md to grants_redesign_design_…
([#2691](#2691))
([5000b2b](5000b2b))
* renames in update operations
([#2702](#2702))
([793c879](793c879))
* showbyid method tests
([#2648](#2648))
([ff5e617](ff5e617))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Policy SDK update
3 participants