-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Monitor CREDIT_QUOTA type #145
Comments
Can confirm this is still an issue. Currently you are unable to create a resource monitor with credit quota other than 0 with all other values resulting in the above error. #111 seems suspect as the cause of this issue. |
We are also running into this. If I'm understanding the original issue #109 correctly, even though this parameter is an int, it is returned from Snowflake as a float? Seems likely that the fix for both issues would be to use an int for the parameter, but to accept a float back from snowflake? |
For anyone looking for a workaround to this problem in the mean time you can use a snowsql run via Terraform to update the credit quota after provisioning the resource monitor. Examples below.
And the ALTER RESOURCE MONITOR &resource_monitor SET CREDIT_QUOTA=&credit_quota; |
Snowflake only accepts credit_quota as an int. However, the `show resource monitors` command returns it as a float. This PR converts the float read from Snowflake into an int. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> ## References Fixes #145 and #109
Snowflake only accepts credit_quota as an int. However, the `show resource monitors` command returns it as a float. This PR converts the float read from Snowflake into an int. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> ## References Fixes Snowflake-Labs#145 and Snowflake-Labs#109
Snowflake only accepts credit_quota as an int. However, the `show resource monitors` command returns it as a float. This PR converts the float read from Snowflake into an int. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> ## References Fixes Snowflake-Labs#145 and Snowflake-Labs#109
Snowflake only accepts credit_quota as an int. However, the `show resource monitors` command returns it as a float. This PR converts the float read from Snowflake into an int. ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> ## References Fixes Snowflake-Labs#145 and Snowflake-Labs#109
I saw issue #109 about converting the credit quota from an int to a float in resource monitors but when I try and create a monitor I'm getting a data type error.
Using the generated SQL but using
5
instead of5.00
creates the object successfully.The text was updated successfully, but these errors were encountered: