feat: Add allowed values (#1028)

* Add allowed_values field to the snowflake_tag resource * Add allowed_values field to the snowflake_tag resource * Fixing doc and adding example for snowflake_tag resource * Fixing doc and adding example for snowflake_tag resource * testing allowed_values * testing allowed_values * testing allowed_values * testing allowed_values * testing allowed_values * testing allowed_values * adding example usage for snowflake_tag resource * minor fixes * Moving ListToSnowflakeString functions to helpers directory * Moving ListToSnowflakeString functions to helpers directory * pull changes from snowflakelabs/terraform-provider-snowflake * Updating import * Updating import for tag * Updating import * Updating acceptance tests of table annd tag for allowed_values * Replaced GetChange() method with Get() * fixing conflict Co-authored-by: Scott Winkler <scott.winkler@snowflake.com> Co-authored-by: Allison Doami <adoami@chanzuckerberg.com>
Snowflake-Labs · May 31, 2022 · e756867 · e756867
1 parent d066d0b
commit e756867
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/helpers/list_to_string_helpers.go b/pkg/helpers/list_to_string_helpers.go
@@ -13,8 +13,7 @@ func ListToSnowflakeString(list []string) string {
 		list[index] = fmt.Sprintf(`'%v'`, strings.ReplaceAll(element, "'", "\\'"))
 	}
 
-	str := fmt.Sprintf(strings.Join(list, ", "))
-	return str
+	return fmt.Sprintf("%v", strings.Join(list, ", "))
 }
 
 // IpListToString formats a list of IPs into a Snowflake-DDL friendly string, e.g. ('192.168.1.0', '192.168.1.100')

diff --git a/pkg/resources/tag.go b/pkg/resources/tag.go
@@ -308,7 +308,7 @@ func UpdateTag(d *schema.ResourceData, meta interface{}) error {
 	// If there is change in allowed_values field
 	if d.HasChange("allowed_values") {
 		if _, ok := d.GetOk("allowed_values"); ok {
-			_, v := d.GetChange("allowed_values")
+			v := d.Get("allowed_values")
 
 			ns := expandAllowedValues(v)