Add validators and ds templates

Snowflake-Labs · Sep 17, 2024 · b5cd8ed · b5cd8ed
1 parent 050436e
commit b5cd8ed
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 16 deletions.
diff --git a/pkg/datasources/masking_policies.go b/pkg/datasources/masking_policies.go
@@ -33,28 +33,32 @@ var maskingPoliciesSchema = map[string]*schema.Schema{
 					ExactlyOneOf: []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
 				},
 				"database": {
-					Type:         schema.TypeString,
-					Optional:     true,
-					Description:  "Returns records for the current database in use or for a specified database.",
-					ExactlyOneOf: []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					Type:             schema.TypeString,
+					Optional:         true,
+					Description:      "Returns records for the current database in use or for a specified database.",
+					ExactlyOneOf:     []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					ValidateDiagFunc: resources.IsValidIdentifier[sdk.AccountObjectIdentifier](),
 				},
 				"schema": {
-					Type:         schema.TypeString,
-					Optional:     true,
-					Description:  "Returns records for the current schema in use or a specified schema. Use fully qualified name.",
-					ExactlyOneOf: []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					Type:             schema.TypeString,
+					Optional:         true,
+					Description:      "Returns records for the current schema in use or a specified schema. Use fully qualified name.",
+					ExactlyOneOf:     []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					ValidateDiagFunc: resources.IsValidIdentifier[sdk.DatabaseObjectIdentifier](),
 				},
 				"application": {
-					Type:         schema.TypeString,
-					Optional:     true,
-					Description:  "Returns records for the specified application.",
-					ExactlyOneOf: []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					Type:             schema.TypeString,
+					Optional:         true,
+					Description:      "Returns records for the specified application.",
+					ExactlyOneOf:     []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					ValidateDiagFunc: resources.IsValidIdentifier[sdk.AccountObjectIdentifier](),
 				},
 				"application_package": {
-					Type:         schema.TypeString,
-					Optional:     true,
-					Description:  "Returns records for the specified application package.",
-					ExactlyOneOf: []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					Type:             schema.TypeString,
+					Optional:         true,
+					Description:      "Returns records for the specified application package.",
+					ExactlyOneOf:     []string{"in.0.account", "in.0.database", "in.0.schema", "in.0.application", "in.0.application_package"},
+					ValidateDiagFunc: resources.IsValidIdentifier[sdk.AccountObjectIdentifier](),
 				},
 			},
 		},

diff --git a/templates/data-sources/masking_policies.md.tmpl b/templates/data-sources/masking_policies.md.tmpl
@@ -0,0 +1,24 @@
+---
+page_title: "{{.Name}} {{.Type}} - {{.ProviderName}}"
+subcategory: ""
+description: |-
+{{ if gt (len (split .Description "<deprecation>")) 1 -}}
+{{ index (split .Description "<deprecation>") 1 | plainmarkdown | trimspace | prefixlines "  " }}
+{{- else -}}
+{{ .Description | plainmarkdown | trimspace | prefixlines "  " }}
+{{- end }}
+---
+
+!> **V1 release candidate** This data source was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the data source if needed. Any errors reported will be resolved with a higher priority. We encourage checking this data source out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960) to use it.
+
+# {{.Name}} ({{.Type}})
+
+{{ .Description | trimspace }}
+
+{{ if .HasExample -}}
+## Example Usage
+
+{{ tffile (printf "examples/data-sources/%s/data-source.tf" .Name)}}
+{{- end }}
+
+{{ .SchemaMarkdown | trimspace }}
diff --git a/templates/data-sources/views.md.tmpl b/templates/data-sources/views.md.tmpl
@@ -0,0 +1,24 @@
+---
+page_title: "{{.Name}} {{.Type}} - {{.ProviderName}}"
+subcategory: ""
+description: |-
+{{ if gt (len (split .Description "<deprecation>")) 1 -}}
+{{ index (split .Description "<deprecation>") 1 | plainmarkdown | trimspace | prefixlines "  " }}
+{{- else -}}
+{{ .Description | plainmarkdown | trimspace | prefixlines "  " }}
+{{- end }}
+---
+
+!> **V1 release candidate** This data source was reworked and is a release candidate for the V1. We do not expect significant changes in it before the V1. We will welcome any feedback and adjust the data source if needed. Any errors reported will be resolved with a higher priority. We encourage checking this data source out before the V1 release. Please follow the [migration guide](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v094x--v0950) to use it.
+
+# {{.Name}} ({{.Type}})
+
+{{ .Description | trimspace }}
+
+{{ if .HasExample -}}
+## Example Usage
+
+{{ tffile (printf "examples/data-sources/%s/data-source.tf" .Name)}}
+{{- end }}
+
+{{ .SchemaMarkdown | trimspace }}