Skip to content

Commit

Permalink
fix: read Database and Schema name during Stream import (#732)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkduo authored Oct 25, 2021
1 parent 30bb7d0 commit 9f747b5
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/resources/stream.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ resource snowflake_stream stream {
Import is supported using the following syntax:

```shell
# format is database name | schema name | on table name
terraform import snowflake_stream.example 'dbName|schemaName|tableName'
# format is database name | schema name | stream name
terraform import snowflake_stream.example 'dbName|schemaName|streamName'
```
4 changes: 2 additions & 2 deletions examples/resources/snowflake_stream/import.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# format is database name | schema name | on table name
terraform import snowflake_stream.example 'dbName|schemaName|tableName'
# format is database name | schema name | stream name
terraform import snowflake_stream.example 'dbName|schemaName|streamName'
10 changes: 10 additions & 0 deletions pkg/resources/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,16 @@ func ReadStream(d *schema.ResourceData, meta interface{}) error {
return err
}

err = d.Set("database", stream.DatabaseName.String)
if err != nil {
return err
}

err = d.Set("schema", stream.SchemaName.String)
if err != nil {
return err
}

err = d.Set("on_table", stream.TableName.String)
if err != nil {
return err
Expand Down
5 changes: 5 additions & 0 deletions pkg/resources/stream_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ func TestAcc_Stream(t *testing.T) {
checkBool("snowflake_stream.test_stream", "show_initial_rows", false),
),
},
{
ResourceName: "snowflake_stream.test_stream",
ImportState: true,
ImportStateVerify: true,
},
},
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/resources/stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ func TestStreamRead(t *testing.T) {
err := resources.ReadStream(d, db)
r.NoError(err)
r.Equal("stream_name", d.Get("name").(string))
r.Equal("database_name", d.Get("database").(string))
r.Equal("schema_name", d.Get("schema").(string))
r.Equal("grand comment", d.Get("comment").(string))

// Test when resource is not found, checking if state will be empty
Expand Down

0 comments on commit 9f747b5

Please sign in to comment.