wip

pkg/acceptance/asserts.go

@@ -2,8 +2,9 @@ package acceptance
 
 import (
 	"fmt"
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"strconv"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
 func IsGreaterOrEqualTo(greaterOrEqualValue int) resource.CheckResourceAttrWithFunc {

pkg/acceptance/bettertestspoc/assert/commons.go

@@ -3,11 +3,12 @@ package assert
 import (
 	"errors"
 	"fmt"
-	"golang.org/x/exp/maps"
 	"strconv"
 	"strings"
 	"testing"
 
+	"golang.org/x/exp/maps"
+
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
@@ -105,7 +106,6 @@ func AssertThatObject(t *testing.T, objectAssert InPlaceAssertionVerifier) {
 	objectAssert.VerifyAll(t)
 }
 
-// TODO: This function should iterate over items and look for list item in attributes that matches ALL items' entries AT ONCE (currently it's a pretty dumb assert running through all attributes)
 func HasListItemsOrderIndependent(resourceKey string, attributePath string, expectedItems []map[string]string) resource.TestCheckFunc {
 	return func(state *terraform.State) error {
 		var actualItems []map[string]string
@@ -120,7 +120,7 @@ func HasListItemsOrderIndependent(resourceKey string, attributePath string, expe
 						if attr == "#" {
 							attrValueLen, err := strconv.Atoi(attrValue)
 							if err != nil {
-								return fmt.Errorf("failed to convert length of the attribute %s: %s", attrKey, err)
+								return fmt.Errorf("failed to convert length of the attribute %s: %w", attrKey, err)
 							}
 							if len(expectedItems) != attrValueLen {
 								return fmt.Errorf("expected to find %d items in %s, but found %d", len(expectedItems), attributePath, attrValueLen)

pkg/acceptance/bettertestspoc/assert/resourceassert/gen/resource_schema_def.go

@@ -41,10 +41,6 @@ var allResourceSchemaDefs = []ResourceSchemaDef{
 		name:   "View",
 		schema: resources.View().Schema,
 	},
-	{
-		name:   "Database",
-		schema: resources.Database().Schema,
-	},
 	{
 		name:   "DatabaseRole",
 		schema: resources.DatabaseRole().Schema,
@@ -57,10 +53,6 @@ var allResourceSchemaDefs = []ResourceSchemaDef{
 		name:   "RowAccessPolicy",
 		schema: resources.RowAccessPolicy().Schema,
 	},
-	{
-		name:   "Schema",
-		schema: resources.Schema().Schema,
-	},
 	{
 		name:   "MaskingPolicy",
 		schema: resources.MaskingPolicy().Schema,