Add support to notify modules of keys loaded by flash on startup #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSully
requested changes
Jan 9, 2023
keydb.conf
Outdated
| @@ -2088,3 +2088,6 @@ active-client-balancing yes | |||
| # disk space or any other I/O error KeyDB will instead use memory. | |||
| # | |||
| # blob-support false | |||
|
|
|||
| # Use this config to notify modules of every key loaded from flash on startup (warning: can make startup much slower) | |||
| # module-notify-flash-load yes | |||
There was a problem hiding this comment.
If this is part of the module API why do we need a config to enable it?
src/server.cpp
Outdated
| @@ -6953,6 +6953,18 @@ void loadDataFromDisk(void) { | |||
|
|
|||
| if (g_pserver->m_pstorageFactory) | |||
| { | |||
| if (g_pserver->config_notify_flash_load) { | |||
There was a problem hiding this comment.
can't you gate this on whether a module is loaded.
src/server.cpp
Outdated
| moduleFireServerEvent(REDISMODULE_EVENT_LOADING, REDISMODULE_SUBEVENT_LOADING_FLASH_START, NULL); | ||
| for (int idb = 0; idb < cserver.dbnum; ++idb) { | ||
| auto spsnapshot = g_pserver->db[idb]->CloneStorageCache(); | ||
| spsnapshot->enumerate([idb](const char *rgchKey, size_t cchKey, const void *, size_t) -> bool { |
There was a problem hiding this comment.
we already enumerate when setting up the StorageCache, can you do this there so we don't double startup time?
JohnSully
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if flash is enabled there is no rdb load, however some modules expect to be notified of keys loaded from rdb, so add the option to have modules notified of keys loaded from flash.