Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distribute function #225

Merged
merged 5 commits into from
Sep 6, 2015
Merged

add distribute function #225

merged 5 commits into from
Sep 6, 2015

Conversation

pingyourid
Copy link
Contributor

a category help masonry to complete distribute on one direction.

and i have a demo in the url:https://github.com/pingyourid/MasonryHelper

@robertjpayne
Copy link
Member

@pingyourid hey it looks pretty good, not sure we're too keen on adding any more API into Masonry as it's now in bugfix only.

Regardless you have a few typos in code such as AxisTypeHorizon vs AxisTypeHorizontal we'd also want those prefixed with MAS to avoid ObjC namespacing issues.

Secondly, we'd need test coverage on these to merge it.

It may be best to publish it as a Masonry+Distribution pod?

Cheers!

@pingyourid
Copy link
Contributor Author

gladly hear from you,I will do it latter,and also make some example!

@pingyourid
Copy link
Contributor Author

I have finished writing my code,can any owner review it if convenience?

@@ -10,6 +10,11 @@
#import "MASConstraintMaker.h"
#import "MASViewAttribute.h"

typedef NS_ENUM(NSUInteger, MASAxisType) {
MASAxisTypeHorizon,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read MASAxisTypeHorizontal to be consistent with the vertical entry.

@robertjpayne
Copy link
Member

@pingyourid I've added a bunch of comments. Mostly are just some typos and language stuff.

@pingyourid
Copy link
Contributor Author

thank you for teach me English hand by hand..

@robertjpayne
Copy link
Member

@pingyourid thanks again for tidying this up, merging it -- will probably do a release in a week or so once iOS 9 releases

robertjpayne added a commit that referenced this pull request Sep 6, 2015
@robertjpayne robertjpayne merged commit 66170a2 into SnapKit:master Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants