-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add distribute function #225
Conversation
@pingyourid hey it looks pretty good, not sure we're too keen on adding any more API into Masonry as it's now in bugfix only. Regardless you have a few typos in code such as Secondly, we'd need test coverage on these to merge it. It may be best to publish it as a Masonry+Distribution pod? Cheers! |
gladly hear from you,I will do it latter,and also make some example! |
I have finished writing my code,can any owner review it if convenience? |
@@ -10,6 +10,11 @@ | |||
#import "MASConstraintMaker.h" | |||
#import "MASViewAttribute.h" | |||
|
|||
typedef NS_ENUM(NSUInteger, MASAxisType) { | |||
MASAxisTypeHorizon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should read MASAxisTypeHorizontal
to be consistent with the vertical entry.
@pingyourid I've added a bunch of comments. Mostly are just some typos and language stuff. |
thank you for teach me English hand by hand.. |
@pingyourid thanks again for tidying this up, merging it -- will probably do a release in a week or so once iOS 9 releases |
a category help masonry to complete distribute on one direction.
and i have a demo in the url:https://github.com/pingyourid/MasonryHelper