Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations #1712

Closed
jxckUK opened this issue Jun 28, 2023 · 0 comments
Closed

Missing translations #1712

jxckUK opened this issue Jun 28, 2023 · 0 comments
Assignees
Labels
🐛 bug Something isn't working 🌐 translation

Comments

@jxckUK
Copy link
Contributor

jxckUK commented Jun 28, 2023

What version of Node.js are you using?

v18.16.1

What operating system are you using?

Ubuntu

What version of SnailyCAD are you currently using?

v1.63.0 d301748

Describe the Bug

There seem to be missing translations for some of the modal tabs when viewing a record.

As you can see there are no translations that have been missed in my languages JSON files.

Expected Behavior

This particular key should utilise an existing translation such as the one in leo.json or a new key should be added.

To Reproduce

image

@casperiv0 casperiv0 added 🐛 bug Something isn't working 🌐 translation labels Jun 28, 2023
@casperiv0 casperiv0 moved this to 🔖 Planned in SnailyCADv4 Main Board Jun 28, 2023
@casperiv0 casperiv0 moved this from 🔖 Planned to 🏗 In progress in SnailyCADv4 Main Board Jun 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in SnailyCADv4 Main Board Jun 28, 2023
casperiv0 pushed a commit that referenced this issue Jun 28, 2023
🔧 Changes: 🔧 
Added to RU translation:
- Locales for `cad-settings`
- Locales for `citizen`
- Locales for `leo`

- ✅  `.json` files are formatted: `yarn format`
- ✅  Translations are correct

In this PR I've added new locales that were introduced in the recent
translations fix (#1712)
Please review and merge this pull request at your earliest convenience.
Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌐 translation
Projects
Archived in project
Development

No branches or pull requests

2 participants