Added support for storing IP addresses at login #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bakk-f4
changed the title
Snaacky
requested changes
May 16, 2023
Snaacky
requested changes
May 18, 2023
| @@ -27,6 +27,18 @@ def save(self): | |||
| db.commit() | |||
|
|
|||
|
|
|||
| class IPAddress(base): | |||
| __tablename__ = "ip_addresses" | |||
There was a problem hiding this comment.
The table name should be something more along the lines of user_logins or something of that nature.
There was a problem hiding this comment.
We already have the login table in PR #186. Let me know which names you prefer for what
| id = Column(Integer, primary_key=True, autoincrement=True) | ||
| address = Column(String(45), nullable=False) | ||
| account_id = Column(Integer, nullable=True) | ||
|
|
There was a problem hiding this comment.
We're not storing the seen_at time that the logins are occurring which makes the logs less useful.
There was a problem hiding this comment.
We are storing the time already in another table in PR #186, let me know if you want aswell another timestamp in this table too. I tought it was not usefull to store two times the same info, we can just join the two tables and we get the same result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP addresses are now being logged to database and associated to each account is logged.
This Issue #128 should be resolved now