Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wp presentation #794

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Conversation

cmeissl
Copy link
Collaborator

@cmeissl cmeissl commented Oct 24, 2022

An attempt to support wp_presentation

based on #792
depends on wayland-rs#574

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 26.03% // Head: 25.46% // Decreases project coverage by -0.57% ⚠️

Coverage data is based on head (6f7a401) compared to base (30e0584).
Patch coverage: 16.74% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   26.03%   25.46%   -0.58%     
==========================================
  Files         117      118       +1     
  Lines       18393    18853     +460     
==========================================
+ Hits         4789     4800      +11     
- Misses      13604    14053     +449     
Flag Coverage Δ
wlcs-core 23.28% <16.74%> (-0.41%) ⬇️
wlcs-output 9.80% <6.55%> (-0.13%) ⬇️
wlcs-pointer-input 25.23% <16.74%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
anvil/src/shell.rs 14.91% <0.00%> (ø)
src/backend/renderer/element/mod.rs 53.92% <0.00%> (-2.49%) ⬇️
src/desktop/wayland/layer.rs 10.04% <0.00%> (-0.52%) ⬇️
anvil/src/state.rs 36.92% <1.80%> (-16.72%) ⬇️
src/desktop/space/mod.rs 54.68% <6.66%> (-5.56%) ⬇️
src/wayland/presentation/mod.rs 12.82% <12.82%> (ø)
src/desktop/wayland/window.rs 47.86% <32.00%> (-3.72%) ⬇️
src/desktop/wayland/utils.rs 74.00% <46.66%> (-15.66%) ⬇️
src/desktop/space/wayland/window.rs 60.69% <56.25%> (-10.23%) ⬇️
src/backend/renderer/damage.rs 74.49% <64.28%> (-2.51%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmeissl cmeissl force-pushed the feature/wp_presentation branch from 6f7a401 to bb81245 Compare October 24, 2022 10:36
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Couple of remarks

@cmeissl cmeissl force-pushed the feature/wp_presentation branch 10 times, most recently from 55dbb66 to 980f7b9 Compare October 28, 2022 17:05
@cmeissl cmeissl force-pushed the feature/wp_presentation branch 5 times, most recently from 1590d4d to 609979f Compare November 6, 2022 21:09
@@ -86,6 +86,11 @@ jobs:
with:
command: update
args: -p log --precise 0.4.14
- name: Downgrade bytemuck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These downgrade steps really do make our buildscripts quite ugly... Maybe we just want to force an explicit version of bytemuck in Smithay?

Although I believe a dependency has this set.

@cmeissl cmeissl force-pushed the feature/wp_presentation branch 5 times, most recently from 2b7fefa to 28e1cbf Compare November 9, 2022 11:43
@cmeissl cmeissl marked this pull request as ready for review November 9, 2022 13:07
@cmeissl cmeissl force-pushed the feature/wp_presentation branch from 28e1cbf to 3ce4441 Compare November 10, 2022 10:02
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I am super happy how this turned out!

@cmeissl cmeissl force-pushed the feature/wp_presentation branch from f1f8778 to 690fa40 Compare November 14, 2022 08:45
@Drakulix Drakulix merged commit 12607b1 into Smithay:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants