-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wp presentation #794
Conversation
Codecov ReportBase: 26.03% // Head: 25.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 26.03% 25.46% -0.58%
==========================================
Files 117 118 +1
Lines 18393 18853 +460
==========================================
+ Hits 4789 4800 +11
- Misses 13604 14053 +449
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6f7a401
to
bb81245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Couple of remarks
55dbb66
to
980f7b9
Compare
1590d4d
to
609979f
Compare
.github/workflows/ci.yml
Outdated
@@ -86,6 +86,11 @@ jobs: | |||
with: | |||
command: update | |||
args: -p log --precise 0.4.14 | |||
- name: Downgrade bytemuck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These downgrade steps really do make our buildscripts quite ugly... Maybe we just want to force an explicit version of bytemuck in Smithay?
Although I believe a dependency has this set.
2b7fefa
to
28e1cbf
Compare
28e1cbf
to
3ce4441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I am super happy how this turned out!
3ce4441
to
f1f8778
Compare
this allows to store some user provided data when queuing a buffer for later retrieval when the buffer has been presented
this adds an abstraction for the wp_presentation protocol
f1f8778
to
690fa40
Compare
An attempt to support
wp_presentation
based on #792
depends on wayland-rs#574