Add support for popup grabs to desktop abstraction #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
feature/popup_grab
branch
from
1e519be to
444a7f2
Compare
elinorbgr
approved these changes
Jan 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for popup grabs to the desktop abstraction.
A popup grab is only allowed before the initial commit, to check for that protocol error the field
committedhas been added to the
XdgPopupSurfaceRoleAttributes.To support exclusive keyboard focus a
KeyboardGrabsimiliar to the existingPointerGrabhas been added.During testing i found an issue with the current popup handling that prevents menu popups from working correctly.
If a popup has no grab it should not receive the keyboard focus, for that a
WindowSurfaceTypehas been addedthat can be used to filter the surfaces in
surfaces_under.